-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chats): Allow image copy #677
Conversation
Download the app installers for this pull request: |
Automated Test ResultsDetails 125 tests across 16 suites Skipped testsAutomated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note |
seems it only supports png writes to clipboard. so i changed it to always write as png |
same here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a relevant question about image types.
Whatever I copy I cant paste it in Uplink but otherwise it does seem to be working. Will approve Screen.Recording.2024-10-11.at.12.15.02.PM.mov |
i think we dont have that feature for chatbar yet. but i tried pasting it elsewhere which worked |
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Browsers (or at least safari) dont seem to allow writing to the clipboard and there is no permission request for that afaik. Because of this copying anything other than text seems to not be possible.