Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(previews): add checks to create payment preview messages #664

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

Jekrimo
Copy link
Contributor

@Jekrimo Jekrimo commented Oct 3, 2024

What this PR does 📖

  • Add extra checks for message previews to include payments, add translations for the preview texts

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Big thing I was looking to do is have the messages apply correctly for who sent, and who is receiving and using the correct grammar depending on who sent/received

image

Additional comments 🎤

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Oct 3, 2024

Automated Test Results

passed  110 passed
skipped  15 skipped

Details

stats  125 tests across 16 suites
duration  13 minutes, 8 seconds
commit  d0133b9

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K2 - Font dropdown should show expected font names
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K15 - Emoji Font dropdown should show expected emoji font names
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K18 - Default Profile Picture Style dropdown should show expected default profile picture styles
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O1, 06 - Message at top of page and custom keybinds listed correctly
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O2, 04 - Clicking a key should activate the Recorded Keys - User can save keybind
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O3 - Action dropdown should display correct keybind actions
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O5 - Clicking Cancel should cancel any custom keybinding the user was trying to add
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O7 - Highlighted border should display when user clicks cancel
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O8 - Clicking Revert Keybindings should revert any custom keybindings the user has saved
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O9 - Highlighted border should be displayed when clicking Revert Keybindings
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O10 - Clicking the backwards arrow should revert specific custom keybinding
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Playwright test execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Oct 5, 2024
Copy link
Collaborator

@lgmarchi lgmarchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a change to let code more clear.

src/lib/components/messaging/ChatPreview.svelte Outdated Show resolved Hide resolved
@lgmarchi lgmarchi added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Oct 7, 2024
@lgmarchi lgmarchi added ⌨️ Ready for Test PR is ready for test and removed Missing dev review Two dev reviews are required on PR QA Requested Changes Changes need to be addressed, something is not working as expected. labels Oct 7, 2024
@phillsatellite phillsatellite merged commit e573ff6 into dev Oct 7, 2024
8 checks passed
@phillsatellite phillsatellite deleted the payment-previews branch October 7, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ Ready for Test PR is ready for test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(sidebar): fix payment preview
4 participants