feat(Chat): Possible to get files from storage to send on chats #657

lgmarchi · 2024-10-02T18:40:31Z

What this PR does 📖

Possible to get files from storage to send on chats
Attachments now are persistent, we can move to other page, other chat, and attachments will keep same for that specific chat

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

github-actions · 2024-10-02T18:43:04Z

Build Log Differences Found:

602a603,606
> DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
> 
> More info: https://sass-lang.com/d/legacy-js-api
>

github-actions · 2024-10-02T18:45:46Z

Download the app installers for this pull request:

github-actions · 2024-10-02T19:07:13Z

Automated Test Results

110 passed
15 skipped

Details

125 tests across 16 suites
13 minutes, 1 second
1241801

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K2 - Font dropdown should show expected font names
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K15 - Emoji Font dropdown should show expected emoji font names
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K18 - Default Profile Picture Style dropdown should show expected default profile picture styles
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O1, 06 - Message at top of page and custom keybinds listed correctly
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O2, 04 - Clicking a key should activate the Recorded Keys - User can save keybind
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O3 - Action dropdown should display correct keybind actions
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O5 - Clicking Cancel should cancel any custom keybinding the user was trying to add
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O7 - Highlighted border should display when user clicks cancel
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O8 - Clicking Revert Keybindings should revert any custom keybindings the user has saved
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O9 - Highlighted border should be displayed when clicking Revert Keybindings
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O10 - Clicking the backwards arrow should revert specific custom keybinding
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

github-actions · 2024-10-02T19:08:31Z

Playwright test execution is complete! You can find the test results report here

github-actions · 2024-10-02T19:32:18Z

Build Log Differences Found:

602a603,606
> DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
> 
> More info: https://sass-lang.com/d/legacy-js-api
>

luisecm · 2024-10-03T00:00:05Z

I am seeing an issue in your PR @lgmarchi - the send button from chat sometimes does nothing

Send a message from user A to user B
User B received message
User B types something in chat bar input
User B clicks on Send Button to send text written in chatbar but nothing happens
Also, write a message in chatbar in press Enter key, message is not sent

…59-wire-up-browse-files

github-actions · 2024-10-03T12:11:21Z

Build Log Differences Found:

602a603,606
> DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
> 
> More info: https://sass-lang.com/d/legacy-js-api
>

github-actions · 2024-10-03T14:33:51Z

Build Log Differences Found:

602a603,606
> DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
> 
> More info: https://sass-lang.com/d/legacy-js-api
>

github-actions · 2024-10-03T20:02:16Z

Build Log Differences Found:

602a603,606
> DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
> 
> More info: https://sass-lang.com/d/legacy-js-api
>

github-actions · 2024-10-03T20:33:38Z

Build Log Differences Found:

602a603,606
> DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
> 
> More info: https://sass-lang.com/d/legacy-js-api
>

github-actions · 2024-10-03T20:41:05Z

Build Log Differences Found:

602a603,606
> DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
> 
> More info: https://sass-lang.com/d/legacy-js-api
>

…59-wire-up-browse-files

github-actions · 2024-10-03T21:29:33Z

Build Log Differences Found:

602a603,606
> DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
> 
> More info: https://sass-lang.com/d/legacy-js-api
>

…59-wire-up-browse-files

phillsatellite · 2024-10-04T17:23:20Z

Sent Lucas a DM it seems like after you send a file if you try to select the same one and send it again it will not send. He replicated and is going to take a look into it

Screen_Recording_2024-10-04_at_1.19.09_PM.mov

luisecm · 2024-10-04T18:34:39Z

@lgmarchi There is an issue when picking up more than one file from local machine to send on chat.

Grabacion.de.pantalla.2024-10-04.a.la.s.12.28.14.p.m.mov

Go to chat
Select upload files
Choose upload from local files
Pick up more than one file on your local machine
Preview is not loaded (bug)
Refresh screen and you will see that sometimes the message is sent and even appears only on remote or local side instead of both sides

lgmarchi added 8 commits September 27, 2024 15:01

Start create browse files from chat to send them (WIP)

9e5c85c

Merge remote-tracking branch 'origin/dev' into 559-wire-up-browse-files

40bb768

Created other files page to just use it whem browse files from chats

00905ea

More progress to browse files and send into chats (WIP)

892ab79

Attaching files from constellation on Chatbar (WIP)

f0d5d66

Adapt code to upload files from storage

e36a8c4

Possible to send files from storage into chats

543270b

Add persistent state on attachments for chats

1df3505

lgmarchi self-assigned this Oct 2, 2024

lgmarchi linked an issue Oct 2, 2024 that may be closed by this pull request

task(Chat): Wire up Browse Files #559

Closed

github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 2, 2024

github-actions bot added the Failed Automated Test Failed Automated Tests CI label Oct 2, 2024

Merge branch 'dev' into 559-wire-up-browse-files

1754755

github-actions bot added the Missing fixing conflict Needs to fix conflicts label Oct 3, 2024

lgmarchi added 2 commits October 3, 2024 09:08

Refactor code to handle attachments count in chat messages

eb60c26

Merge remote-tracking branch 'origin/559-wire-up-browse-files' into 5…

f8ea0fb

…59-wire-up-browse-files

lgmarchi removed the Missing fixing conflict Needs to fix conflicts label Oct 3, 2024

Fixed problem about send messages

360eba9

lgmarchi added 2 commits October 3, 2024 11:51

Update rule about return and don't send message

b14f384

Remove unnecessary code

8ae61de

github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Oct 3, 2024

ashneverdawn approved these changes Oct 3, 2024

View reviewed changes

github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Oct 3, 2024

Improve speed to show files on FileUploadPreview

3d14e33

Merge branch 'dev' into 559-wire-up-browse-files

463d6c6

github-actions bot added the Failed Automated Test Failed Automated Tests CI label Oct 3, 2024

lgmarchi added 2 commits October 3, 2024 18:26

Fix select same file from browse files

a7047b1

Merge remote-tracking branch 'origin/559-wire-up-browse-files' into 5…

ae0e055

…59-wire-up-browse-files

lgmarchi added ⌨️ Ready for Test PR is ready for test and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Oct 3, 2024

lgmarchi added 3 commits October 3, 2024 18:41

Merge remote-tracking branch 'origin/dev' into 559-wire-up-browse-files

9917c0d

Merge branch 'dev' into 559-wire-up-browse-files

3c84383

Merge remote-tracking branch 'origin/559-wire-up-browse-files' into 5…

a60425d

…59-wire-up-browse-files

phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed ⌨️ Ready for Test PR is ready for test labels Oct 4, 2024

Fix problem when send same file from browse files into chats

bfa95f8

Fix FileUploadPreview for local files

e932ffd

github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Oct 4, 2024

Fix deselect file on browse files, when it is opened with file selected

1241801

lgmarchi added ⌨️ Ready for Test PR is ready for test and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Oct 4, 2024

phillsatellite approved these changes Oct 4, 2024

View reviewed changes

phillsatellite added QA Approved PR has been tested by QA Team and removed ⌨️ Ready for Test PR is ready for test labels Oct 4, 2024

lgmarchi merged commit d8a1a9c into dev Oct 4, 2024
8 checks passed

lgmarchi deleted the 559-wire-up-browse-files branch October 4, 2024 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Chat): Possible to get files from storage to send on chats #657

feat(Chat): Possible to get files from storage to send on chats #657

lgmarchi commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024

luisecm commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

phillsatellite commented Oct 4, 2024

luisecm commented Oct 4, 2024

feat(Chat): Possible to get files from storage to send on chats #657

feat(Chat): Possible to get files from storage to send on chats #657

Conversation

lgmarchi commented Oct 2, 2024 • edited Loading

What this PR does 📖

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024 • edited Loading

github-actions bot commented Oct 2, 2024 • edited Loading

Automated Test Results

Details

github-actions bot commented Oct 2, 2024 • edited Loading

github-actions bot commented Oct 2, 2024

luisecm commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

phillsatellite commented Oct 4, 2024

luisecm commented Oct 4, 2024

lgmarchi commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading