fix(state): retry fetching identity

[Flemmli97]

What this PR does 📖

• Retries fetching identity a couple times before giving up

[github-actions]

Download the app installers for this pull request:

• build-macos.zip
• build-ubuntu.zip
• build-android.zip
• build-windows.zip

[github-actions]

Automated Test Results

 120 passed
 2 flaky
 4 skipped

Details

 126 tests across 16 suites
 19 minutes, 56 seconds
 a39d8c9

Flaky tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B7, B57, B58 - Favorites tests
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K18 - Default Profile Picture Style dropdown should show expected default profile picture styles

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

[github-actions]

Playwright test execution is complete! You can find the test results report here

[dariusc93]

Do keep in mind that in the background it will attempt to obtain the identity of another peer and would emit an event once it is discovered.

[Flemmli97]

Do keep in mind that in the background it will attempt to obtain the identity of another peer and would emit an event once it is discovered.

wdym about that? isnt get_identity just a lookup on multipass?

[dariusc93]

wdym about that? isnt get_identity just a lookup on multipass?

It is, but internally, depending on what is used, it will dispatch a task to attempt to request it too if it havent been previously discovered and an event is emitted later if it is discovered.