Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quickprofile): add button and escape exit to quickprofile #586

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Add button and escape exit to quickprofile

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Automated Test Results

passed  119 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  124 tests across 16 suites
duration  19 minutes, 31 seconds
commit  d705c0f

Flaky tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B7, B57, B58 - Favorites tests

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

Copy link

github-actions bot commented Sep 20, 2024

Playwright test execution is complete! You can find the test results report here

@phillsatellite
Copy link
Contributor

Hey Kevin! Just a quick thing it seems like using the esc key to exit isnt working yet. In video I try a couple times but end up having to use the X with the mouse to close

Screen.Recording.2024-09-20.at.12.06.36.PM.mov

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Sep 20, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 21, 2024
@Flemmli97
Copy link
Contributor Author

Hey Kevin! Just a quick thing it seems like using the esc key to exit isnt working yet. In video I try a couple times but end up having to use the X with the mouse to close

Screen.Recording.2024-09-20.at.12.06.36.PM.mov

chrome doesnt trigger keypress for escape. but safari does...
should be fixed now

@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Sep 23, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Sep 23, 2024
@lgmarchi lgmarchi added Ready to Merge This PR is tested and ready for merge and removed Missing dev review Two dev reviews are required on PR labels Sep 24, 2024
@phillsatellite phillsatellite merged commit 4e21f30 into dev Sep 24, 2024
6 checks passed
@phillsatellite phillsatellite deleted the quickprofile_exit branch September 24, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Approved PR has been tested by QA Team Ready to Merge This PR is tested and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(profile): quick profile card from chats does not have exit button
4 participants