Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profile): fix profile integration #585

Merged
merged 10 commits into from
Sep 21, 2024
Merged

fix(profile): fix profile integration #585

merged 10 commits into from
Sep 21, 2024

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Fix integration in profile

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Sep 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Automated Test Results

passed  120 passed
skipped  4 skipped

Details

stats  124 tests across 16 suites
duration  17 minutes, 48 seconds
commit  48b9ecc

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Playwright test execution is complete! You can find the test results report here

stavares843
stavares843 reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

can we fix the logos also?

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Sep 20, 2024
@stavares843
Copy link
Member

i sent a commit for the logs but is still processing on github side.. lol

Captura de ecrã 2024-09-20, às 17 25 15

@stavares843 stavares843 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Sep 20, 2024
@stavares843
Copy link
Member

commit was added now lol

@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 20, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 20, 2024
@lgmarchi lgmarchi removed the Missing dev review Two dev reviews are required on PR label Sep 20, 2024
@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Sep 20, 2024
@stavares843 stavares843 merged commit 60b3885 into dev Sep 21, 2024
3 checks passed
@stavares843 stavares843 deleted the integration_fix branch September 21, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 left review comments

@lgmarchi lgmarchi lgmarchi approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
QA Requested Changes Changes need to be addressed, something is not working as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(quickProfile): Integration accounts appearing incorrectly
4 participants
@Flemmli97 @stavares843 @lgmarchi @phillsatellite