Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(warning): fix warning #580

Merged
merged 5 commits into from
Sep 20, 2024
Merged

chore(warning): fix warning #580

merged 5 commits into from
Sep 20, 2024

Conversation

stavares843
Copy link
Member

What this PR does 📖

  • Fix this warning
Captura de ecrã 2024-09-19, às 15 31 39

how to test

  • npm run build
  • warning should not appear
  • typing indicator should be the same

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Sep 19, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 19, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 19, 2024
Copy link

Build Log Differences Found:

133,139d132
< 2:48:58 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
< 28: export let emojiClickHook;
< 29: export let activeChat;
< 30: export let typing;
<                ^
< 31: const dispatch = createEventDispatcher();
< 32: let markdown = get(SettingsStore.state).messaging.markdownSupport;

Copy link

github-actions bot commented Sep 19, 2024

Automated Test Results

passed  119 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  124 tests across 16 suites
duration  19 minutes, 14 seconds
commit  fe5f9ba

Flaky tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B7, B57, B58 - Favorites tests

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

Copy link

github-actions bot commented Sep 19, 2024

Playwright test execution is complete! You can find the test results report here

@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Sep 19, 2024
Copy link

Build Log Differences Found:

133,139d132
< 6:17:46 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
< 28: export let emojiClickHook;
< 29: export let activeChat;
< 30: export let typing;
<                ^
< 31: const dispatch = createEventDispatcher();
< 32: let markdown = get(SettingsStore.state).messaging.markdownSupport;

Copy link

Build Log Differences Found:

259,265d258
< 4:01:58 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
< 28: export let emojiClickHook;
< 29: export let activeChat;
< 30: export let typing;
<                ^
< 31: const dispatch = createEventDispatcher();
< 32: let markdown = get(SettingsStore.state).messaging.markdownSupport;

@stavares843 stavares843 merged commit 7ba31cf into dev Sep 20, 2024
3 checks passed
@stavares843 stavares843 deleted the sara/fix-warning branch September 20, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants