Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): fix deleting files from send files #579

Merged
merged 5 commits into from
Sep 21, 2024
Merged

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Fix deleting files from send files in chat not working

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Invalid PR title Please make sure PR Title matches starts with add|update|task|chore|feat|fix|refactor label Sep 19, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

Automated Test Results

passed  119 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  124 tests across 16 suites
duration  19 minutes, 6 seconds
commit  43413fb

Flaky tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B7, B57, B58 - Favorites tests

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

Copy link

github-actions bot commented Sep 19, 2024

Playwright test execution is complete! You can find the test results report here

@stavares843 stavares843 changed the title fix deleting files from send files fix(files): fix deleting files from send files Sep 19, 2024
@github-actions github-actions bot removed the Invalid PR title Please make sure PR Title matches starts with add|update|task|chore|feat|fix|refactor label Sep 19, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 19, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 19, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 19, 2024
Copy link

Build Log Differences Found:

122a123,129
> 2:51:05 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
> 28: export let emojiClickHook;
> 29: export let activeChat;
> 30: export let typing;
>                ^
> 31: const dispatch = createEventDispatcher();
> 32: let markdown = get(SettingsStore.state).messaging.markdownSupport;
131,137d137
< 2:50:29 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
< 28: export let emojiClickHook;
< 29: export let activeChat;
< 30: export let typing;
<                ^
< 31: const dispatch = createEventDispatcher();
< 32: let markdown = get(SettingsStore.state).messaging.markdownSupport;

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Sep 19, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Sep 20, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Sep 20, 2024
Copy link

Build Log Differences Found:

263c263
< 4:05:48 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
---
> 4:06:28 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`

@lgmarchi lgmarchi removed the Missing dev review Two dev reviews are required on PR label Sep 20, 2024
@stavares843 stavares843 merged commit d9cf7a5 into dev Sep 21, 2024
5 checks passed
@stavares843 stavares843 deleted the send_files_fix branch September 21, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(files): file deleted from send file preview shows again
4 participants