-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): fix deleting files from send files #579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Invalid PR title
Please make sure PR Title matches starts with add|update|task|chore|feat|fix|refactor
label
Sep 19, 2024
github-actions
bot
added
the
Missing dev review
Two dev reviews are required on PR
label
Sep 19, 2024
Playwright test execution is complete! You can find the test results report here |
stavares843
changed the title
fix deleting files from send files
fix(files): fix deleting files from send files
Sep 19, 2024
github-actions
bot
removed
the
Invalid PR title
Please make sure PR Title matches starts with add|update|task|chore|feat|fix|refactor
label
Sep 19, 2024
Build Log Differences Found: 122a123,129
> 2:51:05 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
> 28: export let emojiClickHook;
> 29: export let activeChat;
> 30: export let typing;
> ^
> 31: const dispatch = createEventDispatcher();
> 32: let markdown = get(SettingsStore.state).messaging.markdownSupport;
131,137d137
< 2:50:29 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
< 28: export let emojiClickHook;
< 29: export let activeChat;
< 30: export let typing;
< ^
< 31: const dispatch = createEventDispatcher();
< 32: let markdown = get(SettingsStore.state).messaging.markdownSupport; |
phillsatellite
added
QA Requested Changes
Changes need to be addressed, something is not working as expected.
and removed
QA Requested Changes
Changes need to be addressed, something is not working as expected.
labels
Sep 19, 2024
phillsatellite
approved these changes
Sep 20, 2024
stavares843
approved these changes
Sep 20, 2024
Build Log Differences Found: 263c263
< 4:05:48 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing`
---
> 4:06:28 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/layouts/Chatbar.svelte:30:11 Chatbar has unused export property 'typing'. If it is for external reference only, please consider using `export const typing` |
lgmarchi
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨