-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wasm): updates wasm + group icon #868
Conversation
Download the app installers for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, that error if you click on it goes to line 194 on src/layouts/page+svelte
https://github.com/Satellite-im/UplinkWeb/blob/dev/src/routes/%2Blayout.svelte#L194
browser - chrome
not private
i had that happen once... and now i cant reproduce it anymore. tried different browsers, refreshing multiple times etc. can you test again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its always reproducible here
Noticed something while testing with Sara. When a user tries to kick themselves from the group nothing happens on their side and they remain in the group. I also still get a bug sometimes when whole app just freezes but it seems totally random Flow: There doesn't seem to be any error in chat when UserB kicks themselves Screen.Recording.2024-11-25.at.10.02.48.AM.mov |
do we even want someone to kick themselves? |
I mean right now thats the only way for a user to leave a group they dont wanna be in |
ok. it seems like that we simply dont receive the conversation deleted event when kicking ourselfs. this is most likely a warp problem and thus i would say we make a ticket for it and handle it in another pr to not hold this up anymore |
Hey Kevin! Gonna approve this today there are just a few things Im gonna create tickets for that I wanted to mention here -Chat remains when user kicks themselves (maybe for the ticket we can instead make it like "User should have a way to leave the group") Thanks for all the work on this pr! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ChatIcon might be confusing for the name but I don't think it's worth changing anything over
What this PR does 📖
Which issue(s) this PR fixes 🔨