Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasm): updates wasm + group icon #868

Merged
merged 12 commits into from
Nov 27, 2024
Merged

chore(wasm): updates wasm + group icon #868

merged 12 commits into from
Nov 27, 2024

Conversation

Flemmli97
Copy link
Contributor

@Flemmli97 Flemmli97 commented Nov 20, 2024

What this PR does 📖

  • Updates wasm to 1.6.2
  • Fixes permission issue with kicking users. A new permission to allow that was added
  • Updated various wasm typings in warp integration
  • Added group/chat icon (technically banner too but atm no way to change and/or display that)
  • Wired up the possibility to change group icon

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 20, 2024
@Flemmli97 Flemmli97 changed the title chore(wasm): updates wasm + icon chore(wasm): updates wasm + group icon Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Download the app installers for this pull request:

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 20, 2024
@stavares843 stavares843 removed the Failed Automated Test Failed Automated Tests CI label Nov 20, 2024
@phillsatellite
Copy link
Contributor

phillsatellite commented Nov 20, 2024

Having some weird issues. This pr broke all 3 of my accounts and Sara's as well. Incognito works fine but most of all the users we will have will not be using incognito browsers to use our app

Switch from dev to this branch (can be a brand new account or old account will still break)

Note that I have tried clearing my cache and restarting my browser over 20 times and no matter what I do I end up at this endless loading screen

This error appears in console -

(in promise) LinkError: WebAssembly.instantiate(): Import # 1 "wbg" "__wbg_friendrequest_new": function import requires a callable

This is Sara's account it was brand new, no friends, no chats, no nothing but still cannot load if we are on this branch
image

My accounts
Screenshot 2024-11-20 at 3 28 48 PM

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 20, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 20, 2024
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, that error if you click on it goes to line 194 on src/layouts/page+svelte

https://github.com/Satellite-im/UplinkWeb/blob/dev/src/routes/%2Blayout.svelte#L194

Captura de ecrã 2024-11-20, às 20 31 21

browser - chrome

not private

Copy link

github-actions bot commented Nov 20, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Nov 20, 2024
@Flemmli97
Copy link
Contributor Author

i had that happen once... and now i cant reproduce it anymore. tried different browsers, refreshing multiple times etc. can you test again?

Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its always reproducible here

@phillsatellite
Copy link
Contributor

Replicated again this morning

Screenshot 2024-11-21 at 11 52 41 AM

@phillsatellite
Copy link
Contributor

So was able to test with Sara with the fix you gave us but I had some weird behavior that Sara wasnt able to replicate. If you cant replicate either its all good wont try to hold this up any longer just wanted to mention it

So with the group that I created everything works fine but when I go to the group that Sara created my entire app freezes up and I get the error that I posted below. If I refresh I can move around the app again until I go to the group Sara created then it breaks again. I created a group with another account and it also seemed to work fine but that was with another account on the same local network so maybe it could be something sometimes happening with users not over local net

Screen_Recording_2024-11-22_at_1.44.38_PM.mov
Screenshot_2024-11-22_at_1 45 02_PM

@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 22, 2024
@phillsatellite
Copy link
Contributor

Noticed something while testing with Sara.

When a user tries to kick themselves from the group nothing happens on their side and they remain in the group.

I also still get a bug sometimes when whole app just freezes but it seems totally random

Flow:
-UserB kicks themselves
-On UserB side nothing changes and they appear as if they are in the group still
-On UserA side it appears that UserB is no longer in the group
-After UserB kicks themselves but groupchat remains on their side any messages sent in the groupchat userB will not receive.

There doesn't seem to be any error in chat when UserB kicks themselves

Screen.Recording.2024-11-25.at.10.02.48.AM.mov

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 25, 2024
@Flemmli97
Copy link
Contributor Author

So was able to test with Sara with the fix you gave us but I had some weird behavior that Sara wasnt able to replicate. If you cant replicate either its all good wont try to hold this up any longer just wanted to mention it

So with the group that I created everything works fine but when I go to the group that Sara created my entire app freezes up and I get the error that I posted below. If I refresh I can move around the app again until I go to the group Sara created then it breaks again. I created a group with another account and it also seemed to work fine but that was with another account on the same local network so maybe it could be something sometimes happening with users not over local net

Screen_Recording_2024-11-22_at_1.44.38_PM.mov

Screenshot_2024-11-22_at_1 45 02_PM

thats strange. as the data there shouldnt be undefined... i could for now add a check for that though

@Flemmli97
Copy link
Contributor Author

Noticed something while testing with Sara.

When a user tries to kick themselves from the group nothing happens on their side and they remain in the group.

I also still get a bug sometimes when whole app just freezes but it seems totally random

Flow: -UserB kicks themselves -On UserB side nothing changes and they appear as if they are in the group still -On UserA side it appears that UserB is no longer in the group -After UserB kicks themselves but groupchat remains on their side any messages sent in the groupchat userB will not receive.

There doesn't seem to be any error in chat when UserB kicks themselves

Screen.Recording.2024-11-25.at.10.02.48.AM.mov

do we even want someone to kick themselves?

@phillsatellite
Copy link
Contributor

Noticed something while testing with Sara.
When a user tries to kick themselves from the group nothing happens on their side and they remain in the group.
I also still get a bug sometimes when whole app just freezes but it seems totally random
Flow: -UserB kicks themselves -On UserB side nothing changes and they appear as if they are in the group still -On UserA side it appears that UserB is no longer in the group -After UserB kicks themselves but groupchat remains on their side any messages sent in the groupchat userB will not receive.
There doesn't seem to be any error in chat when UserB kicks themselves
Screen.Recording.2024-11-25.at.10.02.48.AM.mov

do we even want someone to kick themselves?

I mean right now thats the only way for a user to leave a group they dont wanna be in

@Flemmli97
Copy link
Contributor Author

Noticed something while testing with Sara.
When a user tries to kick themselves from the group nothing happens on their side and they remain in the group.
I also still get a bug sometimes when whole app just freezes but it seems totally random
Flow: -UserB kicks themselves -On UserB side nothing changes and they appear as if they are in the group still -On UserA side it appears that UserB is no longer in the group -After UserB kicks themselves but groupchat remains on their side any messages sent in the groupchat userB will not receive.
There doesn't seem to be any error in chat when UserB kicks themselves
Screen.Recording.2024-11-25.at.10.02.48.AM.mov

do we even want someone to kick themselves?

I mean right now thats the only way for a user to leave a group they dont wanna be in

ok. it seems like that we simply dont receive the conversation deleted event when kicking ourselfs. this is most likely a warp problem and thus i would say we make a ticket for it and handle it in another pr to not hold this up anymore

@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 26, 2024
@phillsatellite
Copy link
Contributor

Hey Kevin! Gonna approve this today there are just a few things Im gonna create tickets for that I wanted to mention here

-Chat remains when user kicks themselves (maybe for the ticket we can instead make it like "User should have a way to leave the group")
-Non-Creator cannot change group photo
-Users cannot clear photo once selected

Thanks for all the work on this pr!

@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Nov 26, 2024
Copy link
Collaborator

@InfamousVague InfamousVague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ChatIcon might be confusing for the name but I don't think it's worth changing anything over

@phillsatellite phillsatellite removed the Missing dev review Two dev reviews are required on PR label Nov 27, 2024
@phillsatellite phillsatellite merged commit 19f32a1 into dev Nov 27, 2024
6 of 7 checks passed
@phillsatellite phillsatellite deleted the wasm-update branch November 27, 2024 17:33
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Automated Test Failed Automated Tests CI QA Approved PR has been tested by QA Team
Projects
None yet
5 participants