Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper plot scales for ancillary plots #3148

Draft
wants to merge 12 commits into
base: release_6.0.1
Choose a base branch
from

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Nov 14, 2024

Description

This sets the default axis scales for plots based on their plot role. All plots are set to log/log in v6.0.0, including residuals, polydispersity, and P(r) plots. This also removes a matplotlib version check that should no longer be relevant.

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@krzywon
Copy link
Contributor Author

krzywon commented Nov 19, 2024

I am making more changes to this in order to resolve #3021. I am removing xtransform and ytransform from the PlotterData object and solely using the DataRole. This will then act as a hint for new plots, but existing plots will not be transformed when new data is appended.

@krzywon krzywon marked this pull request as draft November 19, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants