-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2249: Create a global stylesheet and allow user-built themes #2258
base: main
Are you sure you want to change the base?
Conversation
…the user directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there needs to be a bit of thought about how this will work if we want, say, the ability to change the font size as a user-friendly setting.
…model addition editor
…alizing the type hint in gui utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you want a user-controlled style sheet. I expect that old .css files will be a support headache down the line.
Instead I suggest putting the default style sheet as a resource much like an image file. We can document its location so that interested users can override it, but their changes will be gone with the next install.
…DataExplorerUI.ui
There are now 4 themes. This should be ready for a full review. |
Anything I need to do for the corfunc bit? |
Maybe have a check to see if I missed any inline styles, but I was able to pull many of them out. |
Much better, still need to do something about the window borders, they appear to take the system theme. |
Dark theme disabled and unchecked boxes are pretty much indistinguishable on my screen. |
Other minor points: the check/radio boxes should not be white, and the blue non-focus color is very blue. The white font is too white too. |
…olor palettes in style sheets
Actually could be part of 6.0 .. but maybe a lower priority? Should take a look at |
Pyside6 now natively supports dark and light themes, inherited from the OS. |
This PR is creates a centralized style sheet for all GUI widgets, has the start of two other themes that are currently disabled (Dark and Large Font), and allows for user-created themes.
Current functionality:
setStyleSheet
,setFont
instances with a standardized GuiUtil methodFuture features: