Fix heroparam property name (#703)

This one typo was causing giga softlocks in Orchis
SapiensAnatis · Mar 8, 2024 · e08e19e · e08e19e
1 parent 9fe0843
commit e08e19e
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 14 deletions.
diff --git a/DragaliaAPI/DragaliaAPI.Integration.Test/Other/HeroParamTest.cs b/DragaliaAPI/DragaliaAPI.Integration.Test/Other/HeroParamTest.cs
@@ -30,8 +30,8 @@ public async Task HeroParam_ReturnsData()
             .Should()
             .AllSatisfy(x =>
             {
-                x.EditSkillcharacterId1.Should().Be(0);
-                x.EditSkillcharacterId2.Should().Be(0);
+                x.EditSkillCharacterId1.Should().Be(0);
+                x.EditSkillCharacterId2.Should().Be(0);
                 x.EditSkillLv1.Should().Be(0);
                 x.EditSkillLv2.Should().Be(0);
             });

diff --git a/...DragaliaAPI.Integration.Test/Other/__snapshots__/HeroParamTest.HeroParam_ReturnsData.snap b/...DragaliaAPI.Integration.Test/Other/__snapshots__/HeroParamTest.HeroParam_ReturnsData.snap
@@ -81,8 +81,8 @@
     "BattleGroup": 0,
     "EventPassiveGrowList": [],
     "EventBoostDmg": 0.0,
-    "EditSkillcharacterId1": 10540402,
-    "EditSkillcharacterId2": 10550101,
+    "EditSkillCharacterId1": 10540402,
+    "EditSkillCharacterId2": 10550101,
     "EditSkillLv1": 2,
     "EditSkillLv2": 4,
     "AbilityCrest6Id": 40090001,
@@ -201,8 +201,8 @@
     "BattleGroup": 0,
     "EventPassiveGrowList": [],
     "EventBoostDmg": 0.0,
-    "EditSkillcharacterId1": 0,
-    "EditSkillcharacterId2": 0,
+    "EditSkillCharacterId1": 0,
+    "EditSkillCharacterId2": 0,
     "EditSkillLv1": 0,
     "EditSkillLv2": 0,
     "AbilityCrest6Id": 40090007,
@@ -319,8 +319,8 @@
     "BattleGroup": 0,
     "EventPassiveGrowList": [],
     "EventBoostDmg": 0.0,
-    "EditSkillcharacterId1": 0,
-    "EditSkillcharacterId2": 0,
+    "EditSkillCharacterId1": 0,
+    "EditSkillCharacterId2": 0,
     "EditSkillLv1": 0,
     "EditSkillLv2": 0,
     "AbilityCrest6Id": 40090007,
@@ -437,8 +437,8 @@
     "BattleGroup": 0,
     "EventPassiveGrowList": [],
     "EventBoostDmg": 0.0,
-    "EditSkillcharacterId1": 0,
-    "EditSkillcharacterId2": 0,
+    "EditSkillCharacterId1": 0,
+    "EditSkillCharacterId2": 0,
     "EditSkillLv1": 0,
     "EditSkillLv2": 0,
     "AbilityCrest6Id": 40090001,

diff --git a/DragaliaAPI/DragaliaAPI/Services/Photon/HeroParamService.cs b/DragaliaAPI/DragaliaAPI/Services/Photon/HeroParamService.cs
@@ -166,13 +166,13 @@ private static HeroParam MapHeroParam(DbDetailedPartyUnit unit, FortBonusList fo
         // If AI units are given skill share data, it can cause softlocks for other players
         if (unit is { EditSkill1CharaData: not null, Position: 1 })
         {
-            result.EditSkillcharacterId1 = (int)unit.EditSkill1CharaData.CharaId;
+            result.EditSkillCharacterId1 = (int)unit.EditSkill1CharaData.CharaId;
             result.EditSkillLv1 = unit.EditSkill1CharaData.EditSkillLevel;
         }
 
         if (unit is { EditSkill2CharaData: not null, Position: 1 })
         {
-            result.EditSkillcharacterId2 = (int)unit.EditSkill2CharaData.CharaId;
+            result.EditSkillCharacterId2 = (int)unit.EditSkill2CharaData.CharaId;
             result.EditSkillLv2 = unit.EditSkill2CharaData.EditSkillLevel;
         }
 

diff --git a/Shared/DragaliaAPI.Photon.Shared/Models/HeroParam.cs b/Shared/DragaliaAPI.Photon.Shared/Models/HeroParam.cs
@@ -251,10 +251,10 @@ public class HeroParam
         public float EventBoostDmg { get; set; }
 
         [Key(120)]
-        public int EditSkillcharacterId1 { get; set; }
+        public int EditSkillCharacterId1 { get; set; }
 
         [Key(121)]
-        public int EditSkillcharacterId2 { get; set; }
+        public int EditSkillCharacterId2 { get; set; }
 
         [Key(122)]
         public int EditSkillLv1 { get; set; }