Skip to content

Commit

Permalink
fix(admin-cli): fix the command reports incorrect ERR_INVALID_PARAMET…
Browse files Browse the repository at this point in the history
…ERS error (apache#1699)

apache#1698

Do not set the `backupPath` field of `StartBackupAppRequest` if it's not set
to avoid an `ERR_INVALID_PARAMETERS` error from server. The error is caused
by a conflict check on server side between `StartBackupAppRequest.backupPath`
and `[block_service.hdfs_service].{args}`, the latter has defined a default
backup path.
  • Loading branch information
acelyc111 authored Nov 29, 2023
1 parent 16caf01 commit 432499f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 3 additions & 1 deletion admin-cli/client/meta.go
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,9 @@ func (m *rpcBasedMeta) StartBackupApp(tableID int, providerType string, backupPa
req := &admin.StartBackupAppRequest{
BackupProviderType: providerType,
AppID: int32(tableID),
BackupPath: &backupPath,
}
if backupPath != "" {
req.BackupPath = &backupPath
}
var result *admin.StartBackupAppResponse
err := m.callMeta("StartBackupApp", req, func(resp interface{}) {
Expand Down
1 change: 0 additions & 1 deletion admin-cli/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRF
github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d/go.mod h1:rBZYJk541a8SKzHPHnH3zbiI+7dagKZ0cgpgrD7Fyho=
github.com/andybalholm/brotli v1.0.0/go.mod h1:loMXtMfwqflxFJPmdbJO0a3KNoPuLBgiu3qAvBg8x/Y=
github.com/apache/incubator-pegasus/go-client v0.0.0-20220526071020-be5634371701 h1:J9d8jaC0rKlnf8iQuImyBiDrZnl794JlGMXX8DhMNrs=
github.com/apache/incubator-pegasus/go-client v0.0.0-20220526071020-be5634371701/go.mod h1:vOnSzVwVYmatouq8qEBX+yWV4AvoCTLRpQn6JA+qojs=
github.com/apache/incubator-pegasus/go-client v0.0.0-20220617101220-e49a69d25a52 h1:RvSh9D6x+zfq56hk4vXZyUwjdnpAhBO6pSqcT2nRFgY=
github.com/apache/incubator-pegasus/go-client v0.0.0-20220617101220-e49a69d25a52/go.mod h1:vOnSzVwVYmatouq8qEBX+yWV4AvoCTLRpQn6JA+qojs=
Expand Down

0 comments on commit 432499f

Please sign in to comment.