Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Group artifacts to LPVS folder, apply small fixes #557

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR includes the following changes:

  • removed broken badge from README
  • grouped all LPVS artifacts (Projects, Results) to LPVS folder
  • changed the name of function runOneScan() -> runSingleScan()
  • changed .equals("") to .isEmpty()
  • fixed unit tests
  • update .gitignore

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Changes tested using UTs

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Jul 27, 2024
@o-kopysov o-kopysov added this to the v1.5.3 milestone Jul 27, 2024
@o-kopysov o-kopysov self-assigned this Jul 27, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.57%. Comparing base (af27e74) to head (53cda5c).

Files Patch % Lines
...va/com/lpvs/service/LPVSQueueProcessorService.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #557   +/-   ##
=========================================
  Coverage     92.57%   92.57%           
  Complexity      529      529           
=========================================
  Files            48       48           
  Lines          1737     1737           
  Branches        208      208           
=========================================
  Hits           1608     1608           
  Misses           64       64           
  Partials         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit dccafc6 into main Jul 29, 2024
10 checks passed
@o-kopysov o-kopysov deleted the cli-folder branch July 29, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants