Add result page. #239

kyudori · 2023-10-07T18:13:58Z

Description

LPVS Front-End Reseult Page.
Result Page provides PR informatin and detected file list.

Dashboard(last page) pages will be uploaded.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Code cleanup/refactoring
Documentation update
This change requires a documentation update
CI system update
Test Coverage update

How Has This Been Tested?

Update environment variables of docker-compose.yml file.
Build the lpvs container : docker compose build
Run containers: docker compose up
See the lpvs home page with any browser: http://localhost:7896

For using social login with Naver, Kakao, and Google, fill the necessary information:

Update the application.properties located in src/main/resources:
Enter client-id and client-secret. (Kakao doesn't require a client-secret.)
Update the .env file located in frontend:
Enter your REST_API_KEY.

The values required to implement the login function can be obtained from the link below.
Naver: https://developers.naver.com/products/login/api/api.md
Kakao: https://developers.kakao.com/docs/latest/ko/kakaologin/common
Google: https://cloud.google.com/identity-platform/docs/web/google

Test Configuration:

Java: v11
LPVS Release: v1.1.0

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Signed-off-by: jongmin Lee <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]>

Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>

tiokim

PTAL

frontend/src/pages/History.jsx

frontend/src/pages/Result.jsx

o-konoval · 2023-10-09T15:48:19Z

I tried to check work of this PR.
I cloned this PR on my VM and follow steps for docker build and run-before filled data in application.properties.

But no information on FE:in My Pull Request&My Repo PR-however- PR was handled successfully:
lpvs-lpvs-1 | 2023-10-09 15:21:30.573 INFO 1 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 3
lpvs-lpvs-1 | 2023-10-09 15:21:30.575 INFO 1 --- [ LPVS-ASYNC::2] com.lpvs.service.LPVSQueueService : GitHub Webhook processing...
lpvs-lpvs-1 | 2023-10-09 15:21:30.577 INFO 1 --- [ LPVS-ASYNC::2] com.lpvs.service.LPVSQueueService : com.lpvs.entity.LPVSQueue@510155fa

I filled fields by my Google account info-may be something missed -however I successfully authorized on localhost:7896.
I am sure that You do not have such problem- what may be wrong?

tiokim · 2023-10-10T00:03:21Z

I tried to check work of this PR. I cloned this PR on my VM and follow steps for docker build and run-before filled data in application.properties.

There are PRs in DB: mysql> select * from pull_requests; +----+----------------------------+-------------+----------------------+-------------------------------------------------+-----------------------------------------+-----------------------------+-------------------+-------------------+------------+ | id | scan_date | user | repository_name | url | diff_url | status | pull_request_head | pull_request_base | sender | +----+----------------------------+-------------+----------------------+-------------------------------------------------+-----------------------------------------+-----------------------------+-------------------+-------------------+------------+ | 1 | 2023-10-09 14:34:44.067000 | GitHub hook | userai-dev/dockerapp | userai-dev/dockerapp#35 | https://github.com/userai-dev/dockerapp | Scan completed | userai-dev | userai-dev | userai-dev | | 2 | 2023-10-09 15:20:01.602000 | GitHub hook | userai-dev/dockerapp | userai-dev/dockerapp#36 | https://github.com/userai-dev/dockerapp | Error while posting results | userai-dev | userai-dev | userai-dev | | 3 | 2023-10-09 15:21:30.574000 | GitHub hook | userai-dev/dockerapp | userai-dev/dockerapp#37 | https://github.com/userai-dev/dockerapp | Scan completed | userai-dev | userai-dev | userai-dev | +----+----------------------------+-------------+----------------------+-------------------------------------------------+-----------------------------------------+-----------------------------+-------------------+-------------------+------------+ 3 rows in set (0.00 sec)

But no information on FE:in My Pull Request&My Repo PR-however- PR was handled successfully: lpvs-lpvs-1 | 2023-10-09 15:21:30.573 INFO 1 --- [ main] c.l.service.LPVSQueueProcessorService : PROCESS Webhook id = 3 lpvs-lpvs-1 | 2023-10-09 15:21:30.575 INFO 1 --- [ LPVS-ASYNC::2] com.lpvs.service.LPVSQueueService : GitHub Webhook processing... lpvs-lpvs-1 | 2023-10-09 15:21:30.577 INFO 1 --- [ LPVS-ASYNC::2] com.lpvs.service.LPVSQueueService : com.lpvs.entity.LPVSQueue@510155fa

I filled fields by my Google account info-may be something missed -however I successfully authorized on localhost:7896. I am sure that You do not have such problem- what may be wrong?

Have you set Github ID from the /user/setting page with your github account, userai-dev?

MoonkiHong

Please take a look at my comment.

frontend/src/css/Result_style.css

o-konoval · 2023-10-10T14:14:16Z

Have you set Github ID from the /user/setting page with your github account, userai-dev?

Yes, I obtained GitHub ID and entered it in Profile during login on localhost:7896.
I re-check all again and unfortunately no changes.

Signed-off-by: June Saehwan <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: jongmin Lee <[email protected]>

o-kopysov

LGTM

m-rudyk

I have no objection, approved.

tiokim · 2023-10-10T23:10:31Z

Yes, I obtained GitHub ID and entered it in Profile during login on localhost:7896. I re-check all again and unfortunately no changes.

Can you share your records of the member table too?

tiokim

@kyudori Can you revert Home_style.css and Login_style.css files? There was no problem before, but it seems to have changed.

Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>

kyudori · 2023-10-10T23:55:04Z

@kyudori Can you revert Home_style.css and Login_style.css files? There was no problem before, but it seems to have changed.

Reverting Home_style.css and Login_style.css to previous commit.

tiokim

LGTM

o-konoval · 2023-10-11T12:45:33Z

Yes, I obtained GitHub ID and entered it in Profile during login on localhost:7896. I re-check all again and unfortunately no changes.

Can you share your records of the member table too?

Thanks for supporting.
Yes, it looks like:
mysql> select * from member;

+----+------------------------------+--------+----------+----------+--------------+

+----+------------------------------+--------+----------+----------+--------------+

+----+------------------------------+--------+----------+----------+--------------+

1 row in set (0.00 sec)

tiokim · 2023-10-11T23:21:02Z

+----+------------------------------+--------+----------+----------+--------------+

| id | email | name | nickname | provider | organization |

+----+------------------------------+--------+----------+----------+--------------+

| 1 | [email protected] | Oleg K | NULL | google | NULL |

+----+------------------------------+--------+----------+----------+--------------+

As you can see, the nickname and the organization are NULL. If you put your github id, userai-dev, to the nickname, you can see the appropriate web page.

o-konoval · 2023-10-12T15:17:05Z

Thanks a lot. Now it works- I was confused by GitHub ID value - I read that GitHub ID may be found by request to API- it is an unique number.

GitHub ID may be found in answer of request:
https://api.github.com/users/your_github_user_name
where instead of your_github_user_name you must use the desired GitHub username.

So if possible it would be great if instead GitHub ID on authorization page would be GitHub username or GitHub login- however may be it is my understanding of this term.

Basaeng and others added 2 commits October 6, 2023 19:29

add result page

bdd5b17

Signed-off-by: jongmin Lee <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]>

Add Result frontend page.

234c857

Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>

kyudori requested review from tiokim, MoonkiHong and o-kopysov as code owners October 7, 2023 18:13

o-kopysov requested review from m-rudyk, tdrozdovsky and o-konoval October 9, 2023 07:44

tiokim reviewed Oct 9, 2023

View reviewed changes

frontend/src/pages/History.jsx Show resolved Hide resolved

frontend/src/pages/Result.jsx Outdated Show resolved Hide resolved

MoonkiHong reviewed Oct 10, 2023

View reviewed changes

frontend/src/css/Result_style.css Show resolved Hide resolved

Reflected what reviewed

8ee5c4a

Signed-off-by: June Saehwan <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: jongmin Lee <[email protected]>

o-kopysov approved these changes Oct 10, 2023

View reviewed changes

m-rudyk approved these changes Oct 10, 2023

View reviewed changes

tiokim reviewed Oct 10, 2023

View reviewed changes

Reverted Home_style.css and Login_style.css

657ddc2

Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>

tiokim approved these changes Oct 11, 2023

View reviewed changes

tiokim merged commit 3ad808e into Samsung:main Oct 11, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add result page. #239

Add result page. #239

kyudori commented Oct 7, 2023 •

edited

Loading

tiokim left a comment

o-konoval commented Oct 9, 2023

tiokim commented Oct 10, 2023

MoonkiHong left a comment

o-konoval commented Oct 10, 2023 •

edited

Loading

o-kopysov left a comment

m-rudyk left a comment

tiokim commented Oct 10, 2023

tiokim left a comment

kyudori commented Oct 10, 2023

tiokim left a comment

o-konoval commented Oct 11, 2023 •

edited

Loading

tiokim commented Oct 11, 2023

o-konoval commented Oct 12, 2023

Add result page. #239

Add result page. #239

Conversation

kyudori commented Oct 7, 2023 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

tiokim left a comment

Choose a reason for hiding this comment

o-konoval commented Oct 9, 2023

tiokim commented Oct 10, 2023

MoonkiHong left a comment

Choose a reason for hiding this comment

o-konoval commented Oct 10, 2023 • edited Loading

o-kopysov left a comment

Choose a reason for hiding this comment

m-rudyk left a comment

Choose a reason for hiding this comment

tiokim commented Oct 10, 2023

tiokim left a comment

Choose a reason for hiding this comment

kyudori commented Oct 10, 2023

tiokim left a comment

Choose a reason for hiding this comment

o-konoval commented Oct 11, 2023 • edited Loading

tiokim commented Oct 11, 2023

o-konoval commented Oct 12, 2023

kyudori commented Oct 7, 2023 •

edited

Loading

o-konoval commented Oct 10, 2023 •

edited

Loading

o-konoval commented Oct 11, 2023 •

edited

Loading