AMPscript extensions checker #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @FiB3 to sign the Salesforce Inc. Contributor License Agreement. |
lbuesching
requested changes
Mar 13, 2024
src/vscode/src/checks.ts
Outdated
| const extensionHandlers = { | ||
| "sergey-agadzhanov.AMPscript": { | ||
| handler: () => { | ||
| vscode.window.showInformationMessage(`MCFS [AMPScript] extension is currently not supported by AMPscript Core.`); |
There was a problem hiding this comment.
Let's update this message to convey what not supported means.
"The extension MCFS [AMPScript] is incompatible with AMPscript Core and will prevent AMPscript Core from debugging AMPscript."
src/vscode/src/checks.ts
Outdated
| } | ||
| }, | ||
| "FiB.beautyAmp": { | ||
| handler: () => true |
There was a problem hiding this comment.
Was this to test a positive test case?
|
Ok, updated the warning message. :) |
|
Backward compatibility checks are fine, no changes from this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to help users regarding the issues #13 & #16 by notifying them about the currently incompatible extensions.