Skip to content
This repository has been archived by the owner on Feb 17, 2023. It is now read-only.

Allow the secret to be safely specified externally #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kohsuke
Copy link

@kohsuke kohsuke commented Mar 7, 2013

The way the code is written today expects users to modify the file
that's under the version control system. This is inherently dangerous as
a developer needs to locally edit this file and then be very careful not
to accidentally commit the change in to the repository.

A better way to do this is to either allow these constants to be defined
through a compiler switch (for interactive dekstop development) or in a
separate file (outside the ForcePad source tree and the -I option allows
you to have this import statement resolve the header file correctly.)

This will also work better in a build server, where an in-place
modification to a file is tricky.

The way the code is written today expects users to modify the file
that's under the version control system. This is inherently dangerous as
a developer needs to locally edit this file and then be very careful not
to accidentally commit the change in to the repository.

A better way to do this is to either allow these constants to be defined
through a compiler switch (for interactive dekstop development) or in a
separate file (outside the ForcePad source tree and the -I option allows
you to have this import statement resolve the header file correctly.)

This will also work better in a build server, where an in-place
modification to a file is tricky.
@jhersh
Copy link
Contributor

jhersh commented Mar 7, 2013

Thanks for this! A great improvement.

Unfortunately I'm no longer at salesforce and no one there is maintaining ForcePad. I can't merge this request, but leaving it open should let others see it and use your fork.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants