[SALAD-23116] WebApp - Connect demand alerts page #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2024 02:44
vitto-moz
reviewed
Dec 13, 2024
Comment on lines
59
to
63
| const demandScenario: Record<number, string> = { | ||
| 0: 'Low Demand', | ||
| 50: 'Moderate Demand', | ||
| 80: 'High Demand', | ||
| } |
There was a problem hiding this comment.
packages/web-app/src/modules/demand-alerts-views/constants.ts
let's use this const demandScenario to avoid data duplication
Comment on lines
9
to
12
| export const demandScenario = [ | ||
| { label: 'High Demand', value: '80' }, | ||
| { label: 'Moderate Demand', value: '50' }, | ||
| { label: 'Low Demand', value: '0' }, |
There was a problem hiding this comment.
Suggested change
| export const demandScenario = [ | |
| { label: 'High Demand', value: '80' }, | |
| { label: 'Moderate Demand', value: '50' }, | |
| { label: 'Low Demand', value: '0' }, | |
| export const demandScenario = { | |
| '80': { label: 'High Demand', value: '80' }, | |
| '50': { label: 'Moderate Demand', value: '50' }, | |
| '0': { label: 'Low Demand', value: '0' }, | |
| } |
rners01
reviewed
Dec 23, 2024
Comment on lines
+82
to
+85
| const withCancelSubscriptionSubmitting = | ||
| unsubscribeFromDemandAlertStatus === UnsubscribeFromDemandAlertStatus.SUBMITTING && | ||
| isCurrentDemandedSubscriptionId | ||
| const withCancelSubscriptionFailure = |
There was a problem hiding this comment.
why not name it just
isCancelSubscriptionSubmitting
isCancelSubscriptionFailure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Connect demand alerts page