update novu initialization logic (#1023)

SaladTechnologies · Sep 6, 2023 · b0e4f08 · b0e4f08
1 parent a215c8d
commit b0e4f08
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/packages/web-app/src/App.tsx b/packages/web-app/src/App.tsx
@@ -118,11 +118,11 @@ export const App = withStyles(styles)(
 
     public override render(): ReactNode {
       const { classes, history } = this.props
-      const isAuthenticated = this.store.auth.isAuthenticated
+      const shouldShowNovuBanner = this.store.auth.isAuthenticated && this.store.profile.novuSignature
 
       return (
         <>
-          {isAuthenticated && <NovuNotificationBanner />}
+          {shouldShowNovuBanner && <NovuNotificationBanner />}
           <MobileDevice>
             <div className={classes.mobileMainWindow}>
               <div className={classes.mobileNavigationContainer}>

diff --git a/packages/web-app/src/modules/home-views/NavigationBarContainer.tsx b/packages/web-app/src/modules/home-views/NavigationBarContainer.tsx
@@ -82,6 +82,7 @@ const mapStoreToProps = (store: RootStore): any => {
     username: isAuthenticated ? store.profile.currentProfile?.username : undefined,
     targetReward,
     notifications,
+    novuSignature: store.profile.novuSignature
   }
 }
 

diff --git a/packages/web-app/src/modules/home-views/components/NavigationBarWithNotifications.tsx b/packages/web-app/src/modules/home-views/components/NavigationBarWithNotifications.tsx
@@ -2,7 +2,14 @@ import { NavigationBar, type NavigationBarProps } from '@saladtechnologies/garde
 import type { FunctionComponent } from 'react'
 import { NavigationBarWithNovuNotifications } from './NavigationBarWithNovuNotifications'
 
-export const NavigationBarWithNotifications: FunctionComponent<NavigationBarProps> = (props) => {
+export interface NavigationBarWithNotificationsProps extends NavigationBarProps {
+  novuSignature?: string
+}
+
+export const NavigationBarWithNotifications: FunctionComponent<NavigationBarWithNotificationsProps> = ({
+  novuSignature,
+  ...props
+}) => {
   const notifications = {
     ...props.notifications,
     news: [],
@@ -11,8 +18,9 @@ export const NavigationBarWithNotifications: FunctionComponent<NavigationBarProp
     onOpenNotificationsDrawer: props.notifications.onOpenNotificationsDrawer,
     onCloseNotificationsDrawer: props.notifications.onCloseNotificationsDrawer,
   }
+  const shouldShowNavigationBarWithNovuNotifications = props.username !== undefined && novuSignature !== undefined
 
-  return props.username !== undefined ? (
+  return shouldShowNavigationBarWithNovuNotifications ? (
     <NavigationBarWithNovuNotifications {...props} />
   ) : (
     <NavigationBar {...props} notifications={notifications} />