Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate venv for later steps and remove all conda dependencies #413

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

lochhh
Copy link
Contributor

@lochhh lochhh commented Sep 20, 2024

If you still want to get rid of conda, this should work (workflow run)

@lochhh lochhh changed the base branch from main to gl-ruff-check September 20, 2024 10:08
@lochhh lochhh marked this pull request as ready for review September 20, 2024 10:13
@lochhh lochhh force-pushed the lint-format branch 2 times, most recently from 6de837d to 153da05 Compare September 20, 2024 10:40
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.81%. Comparing base (2107691) to head (48e086b).

Additional details and impacted files
@@              Coverage Diff               @@
##           gl-ruff-check     #413   +/-   ##
==============================================
  Coverage          15.81%   15.81%           
==============================================
  Files                 37       37           
  Lines               3009     3009           
==============================================
  Hits                 476      476           
  Misses              2533     2533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glopesdev glopesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, can you also delete the env_config folder?

@glopesdev glopesdev changed the title Activate venv for later steps Activate venv for later steps and remove all conda dependencies Sep 20, 2024
@glopesdev glopesdev merged commit 1de5c25 into gl-ruff-check Sep 20, 2024
@glopesdev glopesdev deleted the lint-format branch September 20, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants