Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to update sonarcloud scan action #1567

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

andrewelamb
Copy link
Contributor

We were using a deprecated SonarCloud github action before. See this warning, that also wasn't working. This is an attempt to fix that.

@andrewelamb andrewelamb requested a review from a team as a code owner January 9, 2025 15:37
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to merge until the tests finish and the sonarcloud scan runs - If we can confirm coverage is working we're good to merge!

@andrewelamb
Copy link
Contributor Author

@BryanFauble Yep! This will also give us an acurate baseline of what the test coverage currently is at to compare to my other PR.

@andrewelamb andrewelamb marked this pull request as draft January 9, 2025 21:31
@andrewelamb andrewelamb marked this pull request as ready for review January 10, 2025 20:35
@andrewelamb andrewelamb merged commit 32780d6 into develop Jan 10, 2025
8 checks passed
@andrewelamb andrewelamb deleted the update-sonarcloud-github-action branch January 10, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants