Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-1151] Update ReadMe instructions and environment variable when exporting to signoz cloud #1565

Merged
merged 5 commits into from
Jan 7, 2025
Merged

[DPE-1151] Update ReadMe instructions and environment variable when exporting to signoz cloud #1565

merged 5 commits into from
Jan 7, 2025

Conversation

linglp
Copy link
Contributor

@linglp linglp commented Jan 3, 2025 •
edited
Loading

Related to: https://sagebionetworks.jira.com/browse/DPE-1151

Changes

  • Updated instructions when exporting traces to Signoz Cloud
  • Ensured environment variables can be loaded in __init__.py
  • Updated ReadMe instructions to include configuring environment variables when using CLI

Tests

  • Ensured that after setting environment variables in .env, when running tests locally, results can be found on Signoz Cloud
  • Ensured that after setting environment variables in .env, when running schematic api locally, results can be found on Signoz Cloud
  • Ensured that results of test run on Github can be found in Signoz Cloud
  • Ensured that after setting environment variables in .env, when running schematic CLI locally, results can be found on Signoz Cloud

@linglp linglp marked this pull request as ready for review January 6, 2025 16:41
@linglp linglp requested a review from a team as a code owner January 6, 2025 16:41
BryanFauble
BryanFauble approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. Thanks!

thomasyu888
thomasyu888 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Just minor comments - thanks for the review Bryan!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@linglp linglp merged commit 48da1c0 into develop Jan 7, 2025
8 checks passed
@linglp linglp deleted the dpe-1151 branch January 7, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanFauble BryanFauble BryanFauble approved these changes

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linglp @thomasyu888 @BryanFauble