Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF template config location update #146

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Jan 31, 2024

In Slack @afwillia announced that we can maintain the templates config.json somewhere and DCA will reference the link.

the template dropdown config and logo will be referenced by a URL, not the filepath in data_curator_config. This means those files can live elsewhere, like your data model repo.

This is recommended to reduce external PRs just to change the template menu/get faster direct updates.

@allaway @cconrad8 for awareness -- this is for staging first, we'll make this change for prod as well after this is merged.

@afwillia afwillia merged commit 7d798ec into Sage-Bionetworks:staging Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants