Removed druggability-only genes from the gene_metadata pre-processing #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses AG-1579 and also does a good amount of code cleanup/refactoring to reduce code duplication and increase maintainability. The goal of the cleanup is to start moving most of the heavy lifting out of the notebook and into a script with easier-to-maintain code, since this notebook needs to be run periodically. Down the road I want everything to be a script that can be auto-kicked-off, instead of a notebook.
AG-1579:
gene_metadata
file to SynapseCleanup:
data_analysis/agora/notebooks/preprocessing/preprocessing_utils.py
preprocessing_utils.py
preprocesing_utils
functions, which it had previously been duplicating in the notebook.For ease of comparison (the diffs of the notebook are hard to read clearly), here is a human-readable version of:
Code moved:
preprocessing_utils.get_all_adt_ensembl_ids
(refactored quite a bit)preprocessing_utils.standardize_list_item
(list-of-lists code also removed because mygene no longer returns those)preprocessing_utils.merge_duplicate_ensembl_ids
(refactored quite a bit)preprocessing_utils.query_ensembl_version_api