Merge pull request #1310 from Sage-Bionetworks/staging

AG-1339: 3.4.0 to prod

.eslintrc.json

@@ -11,7 +11,8 @@
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "ecmaVersion": "latest",
-    "sourceType": "module"
+    "sourceType": "module",
+    "project": ["./tsconfig.base.json"]
   },
   "plugins": ["@typescript-eslint"],
   "rules": {
@@ -23,6 +24,7 @@
     "@typescript-eslint/ban-ts-comment": "off",
     "@typescript-eslint/no-empty-interface": "off",
     "@typescript-eslint/no-empty-function": "off",
-    "@typescript-eslint/no-this-alias": "off"
+    "@typescript-eslint/no-this-alias": "off",
+    "@typescript-eslint/no-floating-promises": "warn"
   }
 }

.github/workflows/node.js.yml

@@ -0,0 +1,55 @@
+# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs
+
+name: Node.js CI
+
+on:
+  push:
+    branches: [ develop, main ]
+  pull_request:
+    branches: [ develop, main ]
+
+jobs:
+  build:
+    timeout-minutes: 60
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [16.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+    # Allow OIDC Integration (so we can assume the AWS role to deploy)
+    # permissions:
+    #   id-token: write
+    #   contents: read
+    steps:
+    - uses: actions/checkout@v3
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v3
+      with:
+        node-version: ${{ matrix.node-version }}
+        cache: 'npm'
+    - run: npm ci
+    - run: APP_ENV=develop npm run ci:build:develop
+    # Background dev server
+    # - run: npm run dev &
+    - run: npm test
+
+    # - name: Configure AWS Credentials
+    #   uses: aws-actions/configure-aws-credentials@v4
+    #   with:
+    #     aws-region: "us-east-1"
+    #     role-to-assume: "arn:aws:iam::607346494281:role/sagebase-github-oidc-agora-eb-deploy"
+    #     role-session-name: GitHubActions-${{ github.repository_owner }}-${{ github.event.repository.name }}-${{ github.run_id }}
+    #     role-duration-seconds: 1200
+    # - name: Install Playwright Browsers
+    #   run: npx playwright install --with-deps
+    # - name: Run Playwright tests
+    #   run: npx playwright test
+    # - uses: actions/upload-artifact@v3
+    #   if: always()
+    #   with:
+    #     name: playwright-report
+    #     path: playwright-report/
+    #     retention-days: 30

.travis.yml

@@ -26,8 +26,6 @@ before_script:
   - echo -e "[ci-user-prod]\naws_access_key_id=${AwsTravisAccessKey_prod}\naws_secret_access_key=${AwsTravisSecretAccessKey_prod}\n" >> ~/.aws/credentials
   # setup npm dependencies
   - npm install
-  # setup playwright dependencies
-  - npx playwright install --with-deps
 stages:
   - name: test
   - name: eb-deploy-develop
@@ -41,8 +39,6 @@ jobs:
       script:
         - npm run test
         - npm run build
-        - npm run start &
-        - npx playwright test
     - stage: deploy-develop
       if: (NOT type IN (pull_request)) AND (branch = develop)
       node_js: 16.15.0