Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pipfile and add readme note #30

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

BryanFauble
Copy link
Contributor

Problem:
In the pipfile the name of the package does not match the name defined in the setup.cfg. It leads to the error below:

Installing dependencies from Pipfile.lock (e4bbd8)...
[pipenv.exceptions.InstallError]: ERROR: Could not find a version that satisfies the requirement py-orca[all]==1.3.2.post1.dev19+gcdfdad2.d20231026 (from versions: 1.0.0, 1.0.1, 1.1.0, 1.2.0, 1.3.0, 1.3.1, 1.3.2, 1.3.3)
[pipenv.exceptions.InstallError]: ERROR: No matching distribution found for py-orca[all]==1.3.2.post1.dev19+gcdfdad2.d20231026
ERROR: Couldn't install package: {}
 Package installation failed...

Solution:
Correct the name of the package in the pipfile

Testing:
I verified I could use pipfile install -d and all dependencies were installed as expected

@BryanFauble BryanFauble requested a review from BWMac November 7, 2023 23:21
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea1a993) 100.00% compared to head (df969f6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          920       920           
  Branches       140       101   -39     
=========================================
  Hits           920       920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. This was always working before so I wonder if there is something about the newer versions of pipenv that causes this problem.

@BryanFauble BryanFauble merged commit 70964a9 into main Nov 8, 2023
9 of 12 checks passed
@BryanFauble BryanFauble deleted the correct-for-pipfile branch November 8, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants