IT-2396: Exempt redash svc user #1005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaro0508
reviewed
Oct 23, 2023
| @@ -444,6 +444,8 @@ Resources: | |||
| - 'arn:aws:iam::325565585839:user/ran-uploader' | |||
| # scipool IT-2315 | |||
| - prefix: 'arn:aws:iam::237179673806:user/synapse-login-scipoolprod-ServiceUser-' | |||
| # synapseprod IT-2396, service account for redash | |||
There was a problem hiding this comment.
this is the same situation as https://sagebionetworks.jira.com/browse/IT-3123 which, i think, @brucehoff prefers to rotate instead of suppress. You might want to check with him first because i'm not sure if he envisions his preference to be the general case.
There was a problem hiding this comment.
Good point, rotated the key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the IAM user for the redash service user in the synapse prod account to the exceptions.