Maintenance: update GH Action versions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update versions of our github actions. This primarily updates actions from Node 16 to Node 20.
zaro0508
requested changes
Apr 10, 2024
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| uses: actions/setup-python@v5 |
There was a problem hiding this comment.
are you missing the step - run: pipenv run coverage report -m to create coverage reports before - name: upload coverage to coveralls?
There was a problem hiding this comment.
no, I actually meant to remove that line from the other PR, I was just using it for debugging. the test is failing because of the upstream issue linked in the other PR and I chose to leave this PR blocked on the issue instead of port the workaround here
Pull Request Test Coverage Report for Build 8635836694Details
💛 - Coveralls |
zaro0508
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions of our github actions. This primarily updates actions from Node 16 to Node 20.