Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 친구가 등록한 선물 조회 API 구현 #55

Merged
merged 6 commits into from
Jan 13, 2024

Conversation

hysong4u
Copy link
Member

@hysong4u hysong4u commented Jan 12, 2024

Related Issue 🍫

Summary 🍪

-친구가 등록한 선물 조회 API 구현
스크린샷 2024-01-13 오전 4 50 46
726/ebb3f03c-8c1d-4e5d-bcd6-7b306730e89d">

Before i request PR review 🍰

  • 해당 룸의 토너먼트 시작일자와 본인 제외한 친구들 선물 리스트 최신순으로 조회하는 API입니다.
  • 선물 최신순으로 조회하기 위해 Gift 엔티티에 Base엔티티 상속 추가했습니다.
  • 등록한 선물 수정하는 기능은 아직 없어서 생성 일자인 createDate 기준으로 정렬했습니다.

@hysong4u hysong4u added the FEAT 새로운 기능을 추가 label Jan 12, 2024
@hysong4u hysong4u self-assigned this Jan 12, 2024
@hysong4u hysong4u changed the title Feature/#54 gift [feat] 친구가 등록한 선물 조회 API 구현 Jan 12, 2024
Copy link
Contributor

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 👍👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중요한 건 아닌데.. 그리고 개인 취향일 수 있는데 Map이나 response를 만드는 과정은 서비스단에 위임해도 좋을 거 같아요~!! 근데 제 생각이라서 그냥 참고만 하시길 ㅎ.ㅎ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 기능 구현 이후 리팩토링 할 때 참고하겠습니다!

@ziiyouth ziiyouth merged commit 7375ab7 into develop Jan 13, 2024
1 check passed
@hysong4u hysong4u deleted the feature/#54-gift branch February 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT 새로운 기능을 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 친구가 등록한 선물 API 구현
2 participants