[선물홈 세부 페이지] 친구 등록, 2030 세부 페이지 UI 구현 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ExceptAnyone
approved these changes
Jan 9, 2024
imeureka
approved these changes
Jan 9, 2024
Comment on lines
6
to
8
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; |
Comment on lines
+15
to
+22
| <S.GiftsItemWrapper> | ||
| <S.GiftsItemImage></S.GiftsItemImage> | ||
| <S.GiftsItemTitle>어센틱 로고 후디 멜란지 그레이</S.GiftsItemTitle> | ||
| <S.GiftsItemPrice>{price}원</S.GiftsItemPrice> | ||
| <S.GiftsItemUser> | ||
| {name} | 인당 {Math.floor(price / people)}원 | ||
| </S.GiftsItemUser> | ||
| </S.GiftsItemWrapper> |
There was a problem hiding this comment.
컴포넌트를 분리할 수 있다면 분리하자! 라는 마인드의 관점도 추천드립니다! minitimer 부분 처리하는 컴포넌트와 지금 아이템 데이터패칭 부분이 지금 코드에선 같이 존재하니까 이 부분 분리하는 것도 더 좋은 관심사의 분리가 될 수 있을 것 같아 의견을 제시해보아용!
imeureka
approved these changes
Jan 9, 2024
| background-color: ${({ theme }) => theme.colors.white}; | ||
| `; | ||
|
|
||
| export const GiftHomeDetailWrapper = styled.div` |
hoeun0723
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 넘버
구현 사항
Need Review
GiftHomeDetail.styled.ts)을 적용했습니다!component/common/MiniTimer에 분리했습니다!