Rename module pr pipelines #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bischoff
approved these changes
Nov 27, 2024
| @@ -49,7 +49,7 @@ node('pull-request-test-nue') { | |||
| additional_repo_url = params.additional_repo_url; | |||
| terraform_parallelism = params.terraform_parallelism; | |||
| sumaform_gitrepo = "https://github.com/uyuni-project/sumaform.git"; | |||
| sumaform_ref = "master"; | |||
There was a problem hiding this comment.
are we still on the test branch?
There was a problem hiding this comment.
Yes, rename_cucumber_testsuite_module is the branch that has the cucumber testsuite module changes needed for the renaming. I will merge this branch and move the ref back to master once all the renaming is done. The old naming and new naming can't be supported with the same cucumber testsuite module. I need to differentiate as long as we have both naming conventions.
ktsamis
approved these changes
Nov 27, 2024
NamelessOne91
approved these changes
Nov 27, 2024
srbarrios
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modules components changes:
_to separate words and make sure module names are compatible with cucumber testsuite module.Remove venv-salt references:
cucumber testsuite module, simplifying configuration and reducing redundancy.Related to: https://github.com/SUSE/spacewalk/issues/25062
Specific sub-task linked into this PR thread history
Depends on: https://gitlab.suse.de/galaxy/infrastructure/-/merge_requests/989
Depends on uyuni-project/sumaform#1662 but can be merge before. Using this changes in a temporary branch.