Smart Docs - Kernel Boot Parameters #373
Merged
+1,048
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sounix000
force-pushed
the
ssarkar/new-pr-kernel-boot-parameters-smartdocs
branch
from
206f801
to
3558801
Compare
sounix000
force-pushed
the
ssarkar/new-pr-kernel-boot-parameters-smartdocs
branch
from
cbad41f
to
76007fb
Compare
sounix000
force-pushed
the
ssarkar/new-pr-kernel-boot-parameters-smartdocs
branch
from
76007fb
to
35ae6a7
Compare
sounix000
force-pushed
the
ssarkar/new-pr-kernel-boot-parameters-smartdocs
branch
from
dacab8a
to
bc04b62
Compare
taroth21
requested changes
Nov 21, 2024
There was a problem hiding this comment.
@sounix000 : Many thanks, this reads very well! Please don't be shocked about the number of comments - 95% of them apply to metadata changes (we have fine-tuned the templates and rules recently, I added suggestions for all of them).
Other than metadata changes only two minor nitpicks (and I spotted a few typos, which I ignored here because Daria will run her editorial review afterwards anyway and will catch them).
taroth21
approved these changes
Nov 22, 2024
sounix000
force-pushed
the
ssarkar/new-pr-kernel-boot-parameters-smartdocs
branch
from
b95b259
to
2762598
Compare
dariavladykina
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Smart Docs - Kernel Boot Parameters.
This is a new PR because the old PR has become too corrupted with all the Git mess.
Are there any relevant issues/feature requests?
Is this (based on) existing content?