Angi devel to be merged into main #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors and to classic attribute style
…tors and to classic attribute style
…s and to classic attribute style
…s and to classic attribute style
…perators and to classic attribute style
…perators and to classic attribute style
…o new comperators and to classic attribute style
…ts (e.g. lpa_sid_lpt)
…optimizing step duration (loop)
…_SAPHanaController.7 susChkSrv.py.7: mentioned HANA timeouts
…_SAPHanaController.7 susChkSrv.py.7: mentioned HANA timeouts
angelabriel
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Looks good to me. Only 2 typos in the date of 2 man pages found. Would be nice if that can be fixed before we merge.
And the script tools/SAPHanaSR-upgrade-to-angi-demo needs some love to pass the shellcheck (or simply exclude this file from the check for now)
Thanks
|
Also shellcheck should be satisfied now. |
angelabriel
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to 1.2.6