Added check for GNUtls in FIPS140 mode #678
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisu48
requested changes
Dec 2, 2024
| @@ -195,6 +195,10 @@ def test_gnutls_binary(container_per_test: ContainerData) -> None: | |||
| "mv fips-test-gnutls /bin/fips-test-gnutls" | |||
| ) | |||
|
|
|||
| assert "NOT" not in container_per_test.connection.check_output( | |||
There was a problem hiding this comment.
This check is wrong. The requirement states:
should return "library is in FIPS140-3 mode"or "library is in FIPS140-2 mode" or "library is in FIPS140 mode"
So just checking for NOT is not what the requirement states. We need to be rigorous here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that FIPS bci container is in FIPS140 mode to be compliant with Vendor Affirmation tests
https://progress.opensuse.org/issues/167683
[CI:TOXENVS] fips