Add Firefox browser tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrvanes
force-pushed
the
add-firefox-browser
branch
2 times, most recently
from
139a7d6 to
864b343
Compare
mrvanes
force-pushed
the
add-firefox-browser
branch
from
864b343 to
14d2957
Compare
baszoetekouw
requested changes
Jun 5, 2024
run_sram_monitoring.sh
Outdated
| echo "chrome" > browser | ||
| fi | ||
|
|
||
| BROWSER=$(cat browser) |
There was a problem hiding this comment.
Kun je dit nog aanpassen zodat de browser op de command line kan worden opgegeven? Dat maakt het makkelijker om ze om en om aan te roepen van cron/systemd.
| echo sbs_login=$OUTPUT >> ${LOGFILE}.new | ||
|
|
||
| # PAM weblogin test | ||
| OUTPUT=$(python3 pam-monitor.py ${ENV}.yml) | ||
| OUTPUT=$(python3 pam-monitor.py "${ENV}.yml" "$BROWSER") | ||
| echo pam_weblogin=$OUTPUT >> ${LOGFILE}.new |
There was a problem hiding this comment.
Kun je het script ook de gebruikte browser in laten outputten? Bij voorkeur als laatste regel, dat scheelt aanpassingen in zabbix.
baszoetekouw
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.