Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soe redesign cj #179

Closed
wants to merge 57 commits into from
Closed

Soe redesign cj #179

wants to merge 57 commits into from

Conversation

caleb-jones
Copy link

@caleb-jones caleb-jones commented Sep 6, 2017

READY FOR REVIEW

Summary

  • Scenario Outline refactoring + SoE landing pages/department pages Behat content tests

Needed By (Date)

Criticality

  • Not critical

Steps to Test

To run the new landing page tests on engineering.stanford.edu:
From linky_clicky/sites/engineering-redesign use:
../../bin/behat -p <site-profile-name> -s live features/landing_pages

To run other tests, find an appropriate site (JSE, JSA, JSPlus, JSV)
Navigate to the approprate directory,
and use:
../../bin/behat -p <site-profile-name> -s <suite-name> features\example.feature

Affects

  • SoE

Associated Issues and/or People

Related JIRA ticket(s)

Related PRs

More Information

Folks to notify

@cjwest

See Also

@cjwest cjwest requested a review from kbrownell September 7, 2017 19:34
@boznik boznik assigned jbickar and unassigned boznik Sep 14, 2017
@cjwest
Copy link
Member

cjwest commented Oct 13, 2017

@jbickar,

I'd like to get this PR merged before it goes stale. The work Caleb put into refactoring the scenario outlines is beyond the scope of SoE. If it make sense for you to do, will you please review and hopefully merge this PR. If it doesn't make sense who do you think should review this?

@jbickar jbickar removed their assignment Oct 13, 2017
@jbickar
Copy link
Contributor

jbickar commented Oct 13, 2017

Yikes. This is one giant PR.

There's also #175.

boznik assigned jbickar and unassigned boznik 29 days ago <- dirty trick.

The refactoring of the Scenario Outlines within the JSE and SoE features is certainly within SoE scope, but I agree that JSA/JS+/JSV are not.

Can you grab some time on my calendar next week to discuss this? This is not a Friday task.

@cjwest cjwest closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants