Skip to content

Commit

Permalink
8.1.14
Browse files Browse the repository at this point in the history
- D8CORE-4380: updating the SOE link style.
  • Loading branch information
pookmish authored Jul 9, 2021
2 parents c4f93e1 + b926284 commit cd1dbff
Show file tree
Hide file tree
Showing 7 changed files with 43 additions and 50 deletions.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@
- [AMP Tool](https://stanford.levelaccess.net/index.php)
- [Accessibility Manual Test Script](https://docs.google.com/document/d/1ZXJ9RIUNXsS674ow9j3qJ2g1OAkCjmqMXl0Gs8XHEPQ/edit?usp=sharing)
- [HTML Validator](https://validator.w3.org/)
- [Browserstack](https://live.browserstack.com/dashboard) and link to [Browserstack Credentials](https://asconfluence.stanford.edu/confluence/display/SWS/External+Account+Credentials)
- [Browserstack](https://live.browserstack.com/dashboard) and link to [Browserstack Credentials](https://asconfluence.stanford.edu/confluence/display/SWS/External+Account+Credentials)
35 changes: 3 additions & 32 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,39 +1,10 @@
# SOE Basic Sub-Theme

8.x-1.13
8.x-1.9
--------------------------------------------------------------------------------
_Release Date: 2021-06-11_
_Release Date: 2021-07-09_

- D8CORE-4090: Subtheme updates for news after the refactor (#78) (795a546)
- Added theme suggestion alter for search block (0eef723)

8.x-1.12
--------------------------------------------------------------------------------
_Release Date: 2021-05-07_

- D8CORE-3970: adding SOE specific event series teaser styles (#76) (ad3a1dc)
- D8CORE-3991: Correcting the color of the past event label for the gradient banner (#75) (75d7b29)
- D8CORE-3950: adjusting Past Event list page h1 spacing (#74) (3a91ffc)
- Updated components definition in the info.yml (#73) (31fa3b7)

8.x-1.11
--------------------------------------------------------------------------------
_Release Date: 2021-03-05_

- D8CORE-3247: Publications styles (#66) (a487064)
- Update composer.json for stanford_basic (#65) (586fabc)
- D8CORE-3528: updating class name to match reality (#64) (a49c69d)
- D8CORE-3499: fixing the link icons (#61) (a3a1119)
- D8CORE-3246 D8CORE-3487: fixing the external link icons (#63) (414b076)
- D8CORE-3248: publication set up for SOE (#59) (af11eda)

8.x-1.10
--------------------------------------------------------------------------------
_Release Date: 2021-03-16_

- Hotfix for D8CORE-3499, style fixes for soe arrow and external links

>>>>>>> master
- D8CORE-4380: updating the SOE link style. (#80) (b4ab020)

8.x-1.8
--------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion dist/css/theme.css

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion soe_basic.info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ name: SOE Basic
type: theme
description: 'SOE Branding Subtheme.'
package: Stanford
version: 8.x-1.13
version: 8.x-1.9
core_version_requirement: ^9

# Defines the base theme
base theme: stanford_basic

Expand Down
39 changes: 25 additions & 14 deletions src/scss/theme/_events.scss
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,12 @@

h2 {
@include modular-typography(1.3);
line-height: 1.5;

a,
a:link,
a:visited {
a:visited,
a:focus {
@include soe-type-sans-base;
@include soe--link;

Expand Down Expand Up @@ -96,7 +98,8 @@

a,
a:link,
a:visited {
a:visited,
a:focus {
color: $soe-color-black;
font-weight: $su-font-regular;
text-decoration: none;
Expand All @@ -110,16 +113,22 @@
}

// Specific override for the event module.
// Cards appear in the Explore More Events on the event node.
// Lists - event cards.
.su-event-card {
&.su-event-list-item {
.su-event-list-item__details {

h2 {
line-height: 1.5;

> a {
&:active,
&:hover,
&:focus {
color: $soe-color-black;
@include soe--link-hover;

color: $su-color-black;
text-decoration: none;
}
}
Expand All @@ -131,6 +140,8 @@
// Event schedule
.su-event-schedule {
h2 {
line-height: 1.5;

.block__title,
.grouping-title {
font-weight: $su-font-black;
Expand All @@ -144,13 +155,10 @@

color: $su-color-black;

&:hover {
@include soe--link-hover;
}

&:visited,
&:link {
color: $su-color-black;
&:link,
&:focus {
@include soe--link-hover;
}
}
}
Expand All @@ -164,7 +172,8 @@
.su-person-cta__name {
a,
a:link,
a:visited {
a:visited,
a:focus {
color: $su-color-bright-blue;
font-weight: $su-font-black;
text-decoration: none;
Expand Down Expand Up @@ -222,15 +231,17 @@
}

h2 {
a,
a:link,
a:visited {
line-height: 1.5;

a {
@include soe-type-sans-base;
@include soe--link;

color: $su-color-black;

&:hover {
&:hover,
&:focus,
&:active {
@include soe--link-hover;
}

Expand Down
10 changes: 10 additions & 0 deletions src/scss/theme/_news.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

// News List
.su-news-list {

h2 {
line-height: 1.5;
}

.su-news-article {

a {
Expand Down Expand Up @@ -69,6 +74,11 @@
.stanford-news--cards,
.stanford-news-vertical-teaser-term,
.ds-entity--stanford-news {

h2 {
line-height: 1.5;
}

.su-news-vertical-teaser {
.su-news-vertical-teaser__link {
text-decoration: none;
Expand Down
2 changes: 1 addition & 1 deletion src/scss/utilities/mixins/_links.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ $su-color-bay-blue: #016895;
}

@mixin soe--link-hover {
border-bottom: 3px solid $su-color-black;
border-bottom: 5px solid $su-color-black;
}

// SU link-action should be red
Expand Down

0 comments on commit cd1dbff

Please sign in to comment.