-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #24 from SU-SOE/release-8.1.1
"8.x-1.x > 8.1.0-alpha.3
- Loading branch information
Showing
80 changed files
with
1,398 additions
and
34,817 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
# NOT READY FOR REVIEW | ||
- (Edit the above to reflect status) | ||
|
||
# Summary | ||
- TL;DR - what's this PR for? | ||
|
||
# Review By (Date) | ||
- When does this need to be reviewed by? | ||
|
||
# Criticality | ||
- How critical is this PR on a 1-10 scale? Also see [Severity Assessment](https://stanfordits.atlassian.net/browse/D8CORE-1705). | ||
- E.g., it affects one site, or every site and product? | ||
|
||
# Review Tasks | ||
|
||
## Setup tasks and/or behavior to test | ||
|
||
1. Check out this branch | ||
2. Navigate to... | ||
3. Verify... | ||
|
||
## Front End Validation | ||
- [ ] Is the markup using the appropriate semantic tags and passes HTML validation? | ||
- [ ] Cross-browser testing has been performed? | ||
- [ ] Automated accessibility scans performed? | ||
- [ ] Manual accessibility tests performed? | ||
- [ ] Design is approved by @ user? | ||
|
||
## Backend / Functional Validation | ||
### Code | ||
- [ ] Are the naming conventions following our standards? | ||
- [ ] Does the code have sufficient inline comments? | ||
- [ ] Is there anything in this code that would be hidden or hard to discover through the UI? | ||
- [ ] Are there any [code smells](https://blog.codinghorror.com/code-smells/)? | ||
- [ ] Are tests provided? eg (unit, behat, or codeception) | ||
|
||
### Code security | ||
- [ ] Are all [forms properly sanitized](https://www.drupal.org/docs/8/security/drupal-8-sanitizing-output)? | ||
- [ ] Any obvious [security flaws or new areas for attack](https://www.drupal.org/docs/8/security)? | ||
|
||
## General | ||
- [ ] Is there anything included in this PR that is not related to the problem it is trying to solve? | ||
- [ ] Is the approach to the problem appropriate? | ||
|
||
# Affected Projects or Products | ||
- Does this PR impact any particular projects, products, or modules? | ||
|
||
# Associated Issues and/or People | ||
- JIRA ticket(s) | ||
- Other PRs | ||
- Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.) | ||
- Anyone who should be notified? (`@mention` them here) | ||
|
||
# Resources | ||
- [AMP Tool](https://stanford.levelaccess.net/index.php) | ||
- [Accessibility Manual Test Script](https://docs.google.com/document/d/1ZXJ9RIUNXsS674ow9j3qJ2g1OAkCjmqMXl0Gs8XHEPQ/edit?usp=sharing) | ||
- [HTML Validator](https://validator.w3.org/) | ||
- [Browserstack](https://live.browserstack.com/dashboard) and link to [Browserstack Credentials](https://asconfluence.stanford.edu/confluence/display/SWS/External+Account+Credentials) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.