Skip to content

Commit

Permalink
Merge pull request #24 from SU-SOE/release-8.1.1
Browse files Browse the repository at this point in the history
"8.x-1.x >  8.1.0-alpha.3
  • Loading branch information
imonroe authored Aug 7, 2020
2 parents 6c15f8f + a5a061f commit 9775740
Show file tree
Hide file tree
Showing 80 changed files with 1,398 additions and 34,817 deletions.
58 changes: 58 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# NOT READY FOR REVIEW
- (Edit the above to reflect status)

# Summary
- TL;DR - what's this PR for?

# Review By (Date)
- When does this need to be reviewed by?

# Criticality
- How critical is this PR on a 1-10 scale? Also see [Severity Assessment](https://stanfordits.atlassian.net/browse/D8CORE-1705).
- E.g., it affects one site, or every site and product?

# Review Tasks

## Setup tasks and/or behavior to test

1. Check out this branch
2. Navigate to...
3. Verify...

## Front End Validation
- [ ] Is the markup using the appropriate semantic tags and passes HTML validation?
- [ ] Cross-browser testing has been performed?
- [ ] Automated accessibility scans performed?
- [ ] Manual accessibility tests performed?
- [ ] Design is approved by @ user?

## Backend / Functional Validation
### Code
- [ ] Are the naming conventions following our standards?
- [ ] Does the code have sufficient inline comments?
- [ ] Is there anything in this code that would be hidden or hard to discover through the UI?
- [ ] Are there any [code smells](https://blog.codinghorror.com/code-smells/)?
- [ ] Are tests provided? eg (unit, behat, or codeception)

### Code security
- [ ] Are all [forms properly sanitized](https://www.drupal.org/docs/8/security/drupal-8-sanitizing-output)?
- [ ] Any obvious [security flaws or new areas for attack](https://www.drupal.org/docs/8/security)?

## General
- [ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
- [ ] Is the approach to the problem appropriate?

# Affected Projects or Products
- Does this PR impact any particular projects, products, or modules?

# Associated Issues and/or People
- JIRA ticket(s)
- Other PRs
- Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
- Anyone who should be notified? (`@mention` them here)

# Resources
- [AMP Tool](https://stanford.levelaccess.net/index.php)
- [Accessibility Manual Test Script](https://docs.google.com/document/d/1ZXJ9RIUNXsS674ow9j3qJ2g1OAkCjmqMXl0Gs8XHEPQ/edit?usp=sharing)
- [HTML Validator](https://validator.w3.org/)
- [Browserstack](https://live.browserstack.com/dashboard) and link to [Browserstack Credentials](https://asconfluence.stanford.edu/confluence/display/SWS/External+Account+Credentials)
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
# SOE Basic Sub-Theme

8.1.0-alpha.3
--------------------------------------------------------------------------------
_Release Date: 2020-08-07_

- D8CORE-2488: School of Med in the footer (#22) (9e5817e)
- D8CORE-2446: Setting up hero banners for SOE (#17) (b9c25df)
- D8CORE-2445: adding back the underline to buttons on hover/focus (#19) (e93f5ce)
- D8CORE-2308: changing the logo in the footer to have the link to engineering and say Engineering (#21) (84af1c8)
- D8CORE-2443: Fix to font size (#18) (ce0c43d)
- D8CORE-2468: default action link to red (#16) (2bcbf9d)
- D8CORE-2132: fixing events and news (#15) (b0284de)
- D8CORE-2252 (#14) (ad68e91)
- D8CORE-2249: Initial commit for the SOE Events theming. (#12) (b84ad36)
- Back-to-dev (#11) (27622a5)

8.1.0-alpha.2
--------------------------------------------------------------------------------
_Release Date: 2020-07-13_
Expand Down
Binary file removed dist/assets/fonts/fa-brands-400.eot
Binary file not shown.
Binary file removed dist/assets/fonts/fa-brands-400.ttf
Binary file not shown.
Binary file removed dist/assets/fonts/fa-brands-400.woff
Binary file not shown.
Binary file removed dist/assets/fonts/fa-brands-400.woff2
Binary file not shown.
Binary file removed dist/assets/fonts/fa-regular-400.eot
Binary file not shown.
Binary file removed dist/assets/fonts/fa-regular-400.ttf
Binary file not shown.
Binary file removed dist/assets/fonts/fa-regular-400.woff
Binary file not shown.
Binary file removed dist/assets/fonts/fa-regular-400.woff2
Binary file not shown.
Binary file removed dist/assets/img/alert-error.png
Binary file not shown.
Binary file removed dist/assets/img/alert-info.png
Binary file not shown.
Binary file removed dist/assets/img/alert-success.png
Binary file not shown.
Binary file removed dist/assets/img/alert-warning.png
Binary file not shown.
Binary file removed dist/assets/img/arrow-down.png
Binary file not shown.
Binary file removed dist/assets/img/check.png
Binary file not shown.
Binary file added dist/assets/img/stanford_medicine.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 0 additions & 17 deletions dist/assets/svg/alert-error.svg

This file was deleted.

18 changes: 0 additions & 18 deletions dist/assets/svg/alert-info.svg

This file was deleted.

12 changes: 0 additions & 12 deletions dist/assets/svg/alert-success.svg

This file was deleted.

16 changes: 0 additions & 16 deletions dist/assets/svg/alert-warning.svg

This file was deleted.

11 changes: 0 additions & 11 deletions dist/assets/svg/arrow-down.svg

This file was deleted.

3 changes: 0 additions & 3 deletions dist/assets/svg/arrow-right.svg

This file was deleted.

3 changes: 0 additions & 3 deletions dist/assets/svg/arrow-up-right.svg

This file was deleted.

3 changes: 0 additions & 3 deletions dist/assets/svg/caret-down-black.svg

This file was deleted.

3 changes: 0 additions & 3 deletions dist/assets/svg/caret-down-white.svg

This file was deleted.

3 changes: 0 additions & 3 deletions dist/assets/svg/caret-down.svg

This file was deleted.

3 changes: 0 additions & 3 deletions dist/assets/svg/caret-right.svg

This file was deleted.

1 change: 0 additions & 1 deletion dist/assets/svg/check.svg

This file was deleted.

1 change: 0 additions & 1 deletion dist/assets/svg/close-black.svg

This file was deleted.

1 change: 0 additions & 1 deletion dist/assets/svg/close-white.svg

This file was deleted.

3 changes: 0 additions & 3 deletions dist/assets/svg/download.svg

This file was deleted.

Loading

0 comments on commit 9775740

Please sign in to comment.