SOEOPSFY24-125: changed from /magazine to /news for the Engineering news landing page #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imonroe
approved these changes
Jul 24, 2024
|
same thing; I'll look at the tests before I merge. |
|
Same deal here; I'm going to merge this into my branch and proceed. |
imonroe
added a commit
that referenced
this pull request
Aug 28, 2024
* Updated info.yml * wip * updated layout builder restrictions * updated diff * updated responsive table filters * updated drupal core * remove duplicate dependencies and get them via stanford_profile * Downgrade colorbox * Locked subrequests * locked field_group * trying a different version of drupal-patches * locked versions * oembed lazyload * Update engineering_magazine.module (#120) Removed pathauto alter so that regular pathauto pattern applies * SOEOPSFY24-125: changed URL pattern (#119) * enable js_cookie * updating configa * SOEOPS24-114: Fix printable links * stashing some changes * remove version restrictions with new patches in place * locked stanford_caravan to drupal 10.3.1 * fixup * fix test * drush 13.x breaks tests * conflict drush <=13 * fixup event subscriber * fixup * fixup typo * correct version * Updated tests * switch branch on stanford-caravan * updated magazine pathauto patterns, fixed menu, updated styles and navigation block * lock redirect version * Fixup magazine nav test * typo * fixup test * update news page title and some tests * lock autoentitylabel * SOEOPSFY24-6: Removed role=presentation from image cta paragraphs * update redirect * Finished mobile news submenu, added submenu to news collections, fixed soeopsfy24-151 * SOEOPSFY24: Centered hero card text * SOEOPSFY24-96: reduced spacing for list on Media Mentions page * swapped icons for mobile subnav * fixup tests * SOEOPSFY24-156: Styling fixup for news subnave * SOEOPSFY24-157, 156, 149: style fixes for news subnav * fixup styles * Turned on media coverage link * reverted media coverage link --------- Co-authored-by: Dena DeBry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Urgency
Review Tasks
Setup tasks and/or behavior to test
Site Configuration Sync
Front End Validation
Backend / Functional Validation
Code
-All good?
Code security
General
Affected Projects or Products
Associated Issues and/or People
@mentionthem here)Resources