Skip to content

Commit

Permalink
HSD8-744 fix menu keyboard (#446)
Browse files Browse the repository at this point in the history
* HSD8-744 Fix main menu keyboard navigation

* jquery only select the immediate children

Co-authored-by: Sherakama <[email protected]>
  • Loading branch information
pookmish and sherakama authored Jan 17, 2020
1 parent 5de16aa commit 5d04636
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 9 deletions.
4 changes: 2 additions & 2 deletions docroot/themes/humsci/humsci_basic/src/scss/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ html {
color: color(brand);

@include colorful {
color: purple;
color: #800080;
background-color: theme-color(color-purple);
}

@include airy {
color: blue;
color: #0000ff;
font-family: $colorful-font--sans;
}

Expand Down
2 changes: 1 addition & 1 deletion docroot/themes/humsci/humsci_basic/src/scss/_main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,4 @@
// 8. Utilities
// Utilities and helper classes with ability to override anything
// which goes before in the triangle, eg. hide helper class
"base"; // TODO test file
'base'; // TODO test file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
$current-theme: 'airy';

@import "main";
@import 'main';
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
$current-theme: 'colorful';

@import "main";
@import 'main';
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
$current-theme: 'traditional';

@import "main";
@import 'main';

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion docroot/themes/humsci/su_humsci_theme/js/hover_menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@
// Desktop, apply the jquery ui menu and change any mobile classes.
if (window.innerWidth >= 1201) {
$menu.menu({
position: {at: "left bottom"}
position: {at: "left bottom"},
select: function(e, item){
window.location.href = $(item.item).children('a:first-child').attr("href");
}
});
$menu.removeClass('expanded');
$menu.find('.fa-minus').addClass('fa-plus').removeClass('fa-minus');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@

.decanter-nav-submenu .menu-item a,
.decanter-nav-submenu .menu-item span {
border-bottom: 0;
color: $color-bright-red;

@include margin(0 1.5em 10px 0);
Expand Down

0 comments on commit 5d04636

Please sign in to comment.