Release: Editor Experience Improvements (#1305)

* feat: remove toolbar_menu_clean module and refactor the needed functionality within hs_admin

* feat: enable hide manage link perm for contributors

* fix: remove toolbar_menu_clean cruft

* feat: add dblog for dev config split

* shs-4926: component field naming and ordering

* chore: code formatting

* chore: code formatting

* feat: update field_group patches

* fix: patch to correct cke5 default height

* chore: trigger ci deploy

* chore: trigger ci deploy

* shs-4922: add paragraph browser and comp thumbnails

* shs-4939: change callout style default label

* shs-4940: change help text for various fields of paragraphs

* feat(shs-4873): create preprocessor hooks for  edit/create forms

* fix: specific codeception add to menu click

* fix: attempt to force menu tab open

* fix: attempt to force menu tab open

* fix: attempt to force menu tab open

* fix: attempt to force menu tab open

* fix: attempt to force menu tab open

* chore: trigger ci build/deploy

* chore: trigger ci build/deploy

* chore: trigger ci build/deploy

* shs-4926: address pr comments

* shs-4955: account for ck5 css bugs

* fix: make showing the manage menu in toolbar opt-in

* chore: code formatting

* chore: pull release and recompile theme files

* chore: pull release and recompile theme files

* fix: duplicate theme key

* fix: duplicate theme key

* feat: include new theme block config

* feat: remove deprecated custom admin theme blocks

* feat: remove deprecated custom admin theme blocks

* feat: account for claro introduced details/summary markup in codeception tests

* feat: remove row-weights reference in tests as this has been hidden from users

* feat: account for claro introduced details/summary markup in codeception tests

* feat: restore row weight selection

* feat: set permissions for show manage menu in toolbar via hook_update

* fix: row weights with gin

* shs-4926: adjust photo gallery fields per pr comments

* shs-4959: adjusts size of media thumbnail in ck5

* shs-4922: add update hook to set paragraphs_browser for existing sites

* shs-4960: ck5 blockquote style adjustment

* fix: this fixes a small console error related to hs_admin

* fix: remove console

* fix: remove extra space for linting

* shs-4962: adjust minimal html available buttons

* feat: change gin colors to drupal blue instead of stnfd colors

* feat: adjust advanced tabs sort order

* feat: apply tab sort to all cc types

* chore: remove field_validation patch as its now part of the rc1 release

* chore: fix various codeclimate warnings

* chore: simplify codeclimate function complexity

* feat: create update hook to update stanford_gallery paragraphs

* feat: update video embed cest to use paragraphs browser widget

* feat: update video embed and flexible page cest to use paragraphs browser widget

* feat: update flexible page cest testHeroParagraph to use paragraphs browser widget

* feat: test opening Parent link select to select Mega menu option

* fix: update to use paragraphs browser selectors

* fix: correct element selection

* fix: update to use paragraphs browser selectors

* fix: use different selector to search in paragraphs browser

* fix: update to use paragraphs browser selectors

* fix: use different selector to open paragraphs browser

* feat: update private page content cest to use paragraphs browser widget

* fix: update paragraphs browser widget selectors

* fix: update paragraphs browser widget selectors

* fix: use the correct way to select with functional tests

* fix: add wait for paragraphs browse module

* fix: fix wait for paragraphs browse module

* fix: test selectors for paragraphs browse module

* fix: update wait and test selectors

* fix: update wait and use correct paragraph type

* fix: misformatted use statements

* fix: update wait and use correct paragraph type

* fix: update wait and use correct paragraph type

* fix: theme install config should match exported config

* fix:use name for field fill

* fix:use name for field fill

* fix:use name for field fill

* fix:use name for field fill

* fix:add wait for video test

* fix: move tests to allow waiting for paragraphs browser modal to load

* fix: update selector typos

* fix: update search terms for private page

* fix: move private page to use functional tester for paragraphs browser modal

* fix: use css selector

* fix: switch to fill field function

* fix: switch fill field selector

* fix: switch fill field selector to css selector

* fix: update add media selector

* fix: update add media selector

* fix: switch photo album display mode

* fix: change to class selector

* fix: rerun tests

* fix: expand accordion

* fix: add scroll

* fix: class selector update

* fix: use only class selector

* fix: search for block

* fix: use name instead of class

* fix: click without using class

* fix: wait for block to appear as option

* fix: remove acceptance function from functional test

* fix: click with using id

* fix: add wait for text

* fix: click inside collection paragraph

* fix: click using name

* fix: mainpulate window to show back to top block

* fix: selector typo

* fix: wait for file to upload

* fix: fix test later

* fix: fix test later

* fix: fix test later

* fix: fix test later

* fix: fix test later

* fix: fix test later

* fix: fix test later

* fix: fix test later

* fix: fix test later

* feat: removes code button from basic html ck5 format

* fix: fix test later

* fix: fix test later

* fix: fix test later

* shs-4968: removes link features in basic html

* shs-4955: fix ordering conflict between admin and toolbar css

* fix: apply patch on confirm_leave module to prevent warning on node save

* fix: limit size of autocomplete options in ckeditor link dialog

* fix: adjust size of field autocomplete suggestions

* EX improvments codeception fix (#1319)

* fix: update testMobileMenu

* fix: update testMobileMenu circleci uses link class

* fix: update testHeroParagraph

* fix: incorrect indentation

* fix: update testDuplicateScroll

* fix: update testPhotoAlbum

* fix: update testAccordion

* fix: update testBackToTopExists

* fix: remove local acceptPopup testBackToTopExists

* fix: update testTextArea

* fix: update testBackToTopExists if text area component already exists

* fix: update testCollections

* fix: update testBackToTopExists scroll to bottom to display back to top button

* fix: update testBackToTopExists  resize window

* fix: update testBackToTopExists  scroll to footer and use paragraphs

* fix: update testPostcard

* fix: import Locator class

* fix: update testBackToTopExists  wait after executing js scroll script

* fix: update testBackToTopExists  try wait for element

* fix: update testPrivatePageContent

* fix: clean up tests

* fix: remove after function from private page content test

* fix: update testSpotlightSlider

* fix: use paragraphs browser for private pages

* fix: comment out spotlight slider test

* fix: use private page selector

* fix: use private page button value

* fix: add todo

* fix: use correct name for private page components in update hook

* fix: codeclimate long variable

* feat: update jquery_ui_draggable to meet new module requirements

* fix: update styles of ckeditor link autcomplete suggestions

* EX update hook fix (#1325)

* fix: update wysiwyg field if still set to insert_file

* fix: properly insert wysiwyg settings

* fix: update testHeroParagraph

* fix: update tests based on fixed widget settings

* fix: update postcard component for private pages

* fix: removing update hook that is granting perms as it's part of normal config import

* fix: install admin helper module in update hook

---------

Co-authored-by: feynman <[email protected]>

* chore: pull develop and recompile theme files

* fix: codeclimate format issues

* chore: split update hook due to codeclimate warnings

* chore: split update hook due to codeclimate warnings

* fix: missing paragraphs_browser plugin during update hook

* feat: update gin and gin_toolbar to latest release

* fix: change messages color to improve contrast

* feat: update Gin to rc5

* fix: overflow issue with scroll tables appearing ontop submit buttons

* fix: overflow issue with scroll tables appearing ontop submit buttons

* feat: update shortcut menu styles to match manage menu styles

* fix: remove zero unit

* fix: remove zero unit

* fix: comment failing test for deployment reasons

* chore: rerun CI

* fix: add error handling to autocomplete resize js

* chore: pull release and recompile theme files

* fix: always show help text in gin admin theme

* fix: force custom gin admin theme settings to not be ignored

* fix: update class name used to hide text format dropdown

* fix: update ckeditor styes

* chore: update compiled css

* fix: make ckeditor media elements non clickable

* chore: add theme compiled css

* SHS-4984:  Fix Spotlight codeception functional tests (#1328)

* fix(shs-4984): update add media button

* fix(smith-4984): enable spotlight slider test

* fix(smith-4984): count number of images in spotlight slider

* chore: restore missing private page test

* fix: update string with contributor visible text

* fix: move failing acceptance test, update videoEmbedCest

* fix: remove unnecessary test code

* fix: scroll to make caption visible

* chore: add screenshot to check caption text before save

* chore: attempt using different selectors

* chore: use a different string

* chore: move update hook from merge

* chore: move update hook from merge

* fix: change paragraph label in ckeditor heading plugin

* fix: update postcard and spotlight slider paragraphs thumbnails

* fix: change to spotlight slider to spotlight(s)

* fix: restore proper component names

* fix: codeception test error

* tweaks to gitpod setup

* fix: remove unnecessary confirm_leave module patch

* fix: remove unused modules toolbar_menu and toolbar_menu_clean

* fix: add issue URL to patch definition

* fix: add missing issue url to patches

* chore: disable ckeditor 4 and related modules

* fix: refactor hook_form_alter to hook_form_BASE_FORM_ID_alter

* fix: install hooks fixes

* fix: change hook used for hiding tab items

* fix: remove leftover toolbar_menu_clean permissions

* feat: remove site specific body class for admin theme

* feat: move admin interface related hooks to hs_admin module

* fix: rename callback function and update comment

* fix: coding standards issues

* fix: coding standards issues

* Added extra step for gitpod

* fix: move all node tabs weight adjustment to after_build

* fix: move all node tabs weight adjustment to after_build

* chore: trigger ci

* SHS-5013: Add Paragraph Browser to Collection paragraph (#1334)

---------

Co-authored-by: ryanhagerty <[email protected]>
Co-authored-by: Hector Lopez <[email protected]>
Co-authored-by: Andrés Díaz Soto <[email protected]>
Co-authored-by: Mike Decker <[email protected]>

.codeclimate.yml

@@ -27,6 +27,9 @@ plugins:
   # Without the .stylelintrc file it will run with the defaults.
   stylelint:
     enabled: true
+    checks:
+      property-no-unknown:
+        enabled: false
   phpcodesniffer:
     enabled: true
     checks:

.gitpod.yml

@@ -44,17 +44,15 @@ tasks:
       mysql -u root -e 'CREATE DATABASE IF NOT EXISTS drupal_default; CREATE DATABASE IF NOT EXISTS drupal' &&
       blt sws:keys &&
       blt source:build:simplesamlphp-config &&
-      drush sql-sync @hs_colorful.prod @self --extra-dump='--no-tablespaces --insert-ignore' -y &&
-      drush updb -y &&
-      blt drupal:toggle:modules &&
-      drush cim --partial -y &&
-      drush cim --partial -y
+      mysql -e 'SET GLOBAL max_allowed_packet=67108864;' &&
+      blt drupal:sync --site=hs_colorful -n &&
+      drush sql-sync @hs_colorful.local @self -y
 
     command: >
       git config core.fileMode false &&
       blt blt:telemetry:disable --no-interaction &&
       git remote set-url origin [email protected]:SU-HSDO/suhumsci.git &&
       apache2ctl restart &&
-      gp await-port 8001 &&
+      gp ports await 8001 &&
       drush uli &&
       drush uli | xargs gp preview --external

composer.json

@@ -185,12 +185,15 @@
         "drupal/field_permissions": "^1.1",
         "drupal/field_validation": "^1.0@beta",
         "drupal/fontawesome": "^2.22",
+        "drupal/gin": "^3.0",
+        "drupal/gin_toolbar": "^1.0",
         "drupal/google_analytics": "^4.0",
         "drupal/hal": "^1.0",
         "drupal/honeypot": "^2.0",
         "drupal/hook_event_dispatcher": "^4.0@alpha",
         "drupal/imagemagick": "^3.1",
         "drupal/insert": "^2.0",
+        "drupal/jquery_ui_draggable": "^2.0",
         "drupal/jquery_ui_menu": "^2.0",
         "drupal/jsonapi_extras": "^3.21",
         "drupal/key": "^1.14",
@@ -217,6 +220,7 @@
         "drupal/nobots": "^1.0",
         "drupal/node_revision_delete": "^1.0@RC",
         "drupal/page_cache_query_ignore": "^2.2",
+        "drupal/paragraphs_browser": "^1.1",
         "drupal/paragraphs_edit": "^2.0@alpha",
         "drupal/path_redirect_import": "^2.0",
         "drupal/pathauto": "^1.8",
@@ -323,19 +327,25 @@
                 "https://www.drupal.org/project/drupal/issues/1349080": "https://www.drupal.org/files/issues/2021-04-02/1349080-487.patch",
                 "https://www.drupal.org/project/drupal/issues/3306916": "https://www.drupal.org/files/issues/2022-08-30/file_validate_size.patch",
                 "drupallink conflict with anchorlink": "patches/drupallink.patch",
-                "views form null fix": "patches/core-views.patch"
+                "views form null fix": "patches/core-views.patch",
+                "https://www.drupal.org/project/drupal/issues/3241295": "https://www.drupal.org/files/issues/2023-02-02/3241295-d9.5-101.patch",
+                "CKEditor 5 headings plugin paragraph label change": "patches/ckeditor5-paragraph-rename.patch"
             },
             "drupal/ds": {
                 "https://www.drupal.org/project/ds/issues/2939322": "https://www.drupal.org/files/issues/2020-01-07/ds-content_entity-2939322-11.patch"
             },
             "drupal/fakeobjects": {
                 "https://www.drupal.org/project/fakeobjects/issues/3002953": "https://www.drupal.org/files/issues/2020-06-22/fakeobjects-missing_plugin-3002953-5.patch"
             },
+            "drupal/gin": {
+                "https://www.drupal.org/project/gin/issues/3276752": "https://www.drupal.org/files/issues/2022-12-07/gin-stick-after-ajax-reload-3276752-23.patch"
+            },
             "drupal/fast_404": {
                 "https://www.drupal.org/project/fast_404/issues/2838359": "https://www.drupal.org/files/issues/2022-06-16/fast_404-honor_redirects-2838359-50.patch"
             },
             "drupal/field_group": {
-                "https://www.drupal.org/project/field_group/issues/2969051": "https://www.drupal.org/files/issues/2022-09-20/2969051-66.patch"
+                "https://www.drupal.org/project/field_group/issues/2969051": "https://www.drupal.org/files/issues/2023-04-24/2969051-99.patch",
+                "https://www.drupal.org/project/field_group/issues/2787179": "https://www.drupal.org/files/issues/2023-04-07/2787179-highlight-html5-validation-85.patch"
             },
             "drupal/focal_point": {
                 "https://www.drupal.org/project/focal_point/issues/3328807": "https://www.drupal.org/files/issues/2023-01-06/3328807-focal_point-image_width_when_no_image_to_crop.patch"

config/default/block.block.claro_breadcrumbs.yml

@@ -0,0 +1,22 @@
+uuid: 0793b1ef-954a-4cd0-9018-f0a4d6c41761
+langcode: en
+status: true
+dependencies:
+  module:
+    - system
+  theme:
+    - claro
+_core:
+  default_config_hash: NjcxOBrPOiK5-38t56DwFBDVY4yer7YSlbRWXFuHe7A
+id: claro_breadcrumbs
+theme: claro
+region: breadcrumb
+weight: 0
+provider: null
+plugin: system_breadcrumb_block
+settings:
+  id: system_breadcrumb_block
+  label: Breadcrumbs
+  label_display: '0'
+  provider: system
+visibility: {  }

config/default/block.block.seven_content.yml → config/default/block.block.claro_content.yml

@@ -1,15 +1,15 @@
-uuid: ca356d89-2a99-4a2f-b679-8be3b6cfc02c
+uuid: 69f5a69f-e27c-4324-b267-f96fd0b204c7
 langcode: en
 status: true
 dependencies:
   module:
     - system
   theme:
-    - seven
+    - claro
 _core:
-  default_config_hash: OLvNDDzewXPxlm6tSQO9AiwOpBPkUzRzlVapESVO4nQ
-id: seven_content
-theme: seven
+  default_config_hash: a0Yyx1GeyKarZ4T_yXQBR_ZFKnXiFLtxAb6gWLd8nr0
+id: claro_content
+theme: claro
 region: content
 weight: 0
 provider: null

config/default/block.block.claro_help.yml

@@ -0,0 +1,22 @@
+uuid: 5517c806-cdef-4594-866b-717c3bbab5a0
+langcode: en
+status: true
+dependencies:
+  module:
+    - help
+  theme:
+    - claro
+_core:
+  default_config_hash: jccFSSVqV0WCDb6NtML1VWAWTtDbZ-zn5YgTRMgMrIM
+id: claro_help
+theme: claro
+region: help
+weight: 0
+provider: null
+plugin: help_block
+settings:
+  id: help_block
+  label: Help
+  label_display: '0'
+  provider: help
+visibility: {  }

config/default/block.block.claro_local_actions.yml

@@ -0,0 +1,20 @@
+uuid: fac001fd-d175-4e26-a0d3-9079c9246f74
+langcode: en
+status: true
+dependencies:
+  theme:
+    - claro
+_core:
+  default_config_hash: CdXfDmRgAvms7EQovxxWPdYi0GitxeRbVtScYK16ZH0
+id: claro_local_actions
+theme: claro
+region: content
+weight: -10
+provider: null
+plugin: local_actions_block
+settings:
+  id: local_actions_block
+  label: 'Primary admin actions'
+  label_display: '0'
+  provider: core
+visibility: {  }

config/default/block.block.su_humsci_admin_messages.yml → config/default/block.block.claro_messages.yml

@@ -1,16 +1,16 @@
-uuid: 378fbd68-d362-4309-8282-ff607e550c65
+uuid: df1f920d-9800-454b-a9a3-ee831392f98f
 langcode: en
-status: false
+status: true
 dependencies:
   module:
     - system
   theme:
-    - su_humsci_admin
+    - claro
 _core:
-  default_config_hash: XPR-s7h2b8hmtq4l2luLGnYZ-KxuOetKFX3TZjQFJtc
-id: su_humsci_admin_messages
-theme: su_humsci_admin
-region: header
+  default_config_hash: '-Ac3ISpIT0PQ-whzD7_dw0SdKi6dAbRFNWdSjOiVDqg'
+id: claro_messages
+theme: claro
+region: highlighted
 weight: 0
 provider: null
 plugin: system_messages_block