Check for existing ingress when appending to status #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STRRL
requested changes
Jun 1, 2024
pkg/controller/ingress-controller.go
Outdated
Comment on lines
102
to
118
| origin.Status.LoadBalancer.Ingress = append(origin.Status.LoadBalancer.Ingress, | ||
| networkingv1.IngressLoadBalancerIngress{ | ||
| Hostname: i.tunnelClient.TunnelDomain(), | ||
| Ports: []networkingv1.IngressPortStatus{{ | ||
| Protocol: v1.ProtocolTCP, | ||
| Port: 443, | ||
| }}, | ||
| }, | ||
| ) | ||
| hostname := i.tunnelClient.TunnelDomain() | ||
| matchesHostname := func(ingress networkingv1.IngressLoadBalancerIngress) bool { | ||
| return ingress.Hostname == hostname | ||
| } | ||
| if !slices.ContainsFunc(origin.Status.LoadBalancer.Ingress, matchesHostname) { | ||
| origin.Status.LoadBalancer.Ingress = append(origin.Status.LoadBalancer.Ingress, | ||
| networkingv1.IngressLoadBalancerIngress{ | ||
| Hostname: hostname, | ||
| Ports: []networkingv1.IngressPortStatus{{ | ||
| Protocol: v1.ProtocolTCP, | ||
| Port: 443, | ||
| }}, | ||
| }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
the kubernetes controller / operator works as a observe -> reconcile -> update status pattern, so it's better to regenerate Ingress array every time, instead of append to the origin slice.
also, there are other best practices (which are picky) like:
- always deep copy the oiring object before call the
.Updatemethod - only update Status subresource
There was a problem hiding this comment.
Ok awesome, I think I've got it. Does that look better? I really appreciate your patience!
There was a problem hiding this comment.
one more step, please call DeepCopy before change the value of Ingress field
rest looks good to me! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for an existing ingress matching the hostname before blindly appending it to the status.
Should resolve #88
Is it worthwhile to remove duplicates for anyone that may have been affected by this?