Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying a different cloudflared image #71

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

UnstoppableMango
Copy link
Contributor

Should allow for pinning versions

@STRRL
Copy link
Owner

STRRL commented Jan 8, 2024

Awesome! Thanks for your contribution! @UnstoppableMango

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (12c0629) 25.99% compared to head (55d5bcb) 25.91%.

Files Patch % Lines
pkg/controller/controlled-cloudflared-connector.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   25.99%   25.91%   -0.09%     
==========================================
  Files           9        9              
  Lines         627      629       +2     
==========================================
  Hits          163      163              
- Misses        454      456       +2     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@STRRL STRRL merged commit c685e37 into STRRL:master Jan 8, 2024
3 checks passed
@UnstoppableMango UnstoppableMango deleted the cloudflared-image branch January 8, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants