Support specifying an alternate number of replicas for cloudflared #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflared should [support HA configurations out of the box](https://blog.cloudflare.com/highly-available-and-highly-scalable-cloudflare-tunnels/) with no extra work from the controller. This also means it should be possible to support a DaemonSet option for cloudflared.
UnstoppableMango
force-pushed
the
replicas
branch
from
e8b4e33 to
8c80388
Compare
I'm not sure if you prefer CLI args or env vars, but the env vars seem to require less "prop drilling"
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 25.91% 25.70% -0.21%
==========================================
Files 9 9
Lines 629 634 +5
==========================================
Hits 163 163
- Misses 456 461 +5
Partials 10 10 ☔ View full report in Codecov by Sentry. |
|
Thanks for your contribution!!! @UnstoppableMango |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflared should support HA configurations out of the box with no extra work from the controller.
This also means it should be possible to support a DaemonSet option for cloudflared.