fix: only consider matching ingress class #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for writing this project. I ran into an issue when running this project in my cluster with 2 ingresses (an existing ingress class for nginx, and this one):
It seemed to consider the ingress configuration no matter which ingress class I had set on the ingress object, which meant it tried to configure all the ingresses including the ones nginx was managing. This PR prevents that by filtering the controlled ingress classes to the ones that match the set controller class name.