-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): allow services of type externalname #46
Conversation
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Hi @oliverbaehler, sorry for the late response. You work is awsome, but it changes the go package name so I am afraid that I could not merge it. Would you like change |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 26.20% 21.38% -4.82%
==========================================
Files 9 11 +2
Lines 622 706 +84
==========================================
- Hits 163 151 -12
- Misses 449 554 +105
+ Partials 10 1 -9 ☔ View full report in Codecov by Sentry. |
Oh hi @STRRL, yeah it's currently a fork of your project. Would you consider merging all the changes? Its quiet a lot .. :D. Then i will change the package path |
Sorry it seemed you have abandoned this project 3: |
I am not sure. I just found your awesome work and I am trying to merge it.
yeah you're right, I really don't have much time for this project. The fork is great! I think I would better not try to merge your code directly. Maybe I would use your code as references and also implement some awesome features. Thanks! |
I am going to close this PR. If you want me to reference your awesome fork on this repos README.md, feel free to open another PR! |
This feature allows us to redirect traffic to external resources or additional ingress controllers :)