Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): allow services of type externalname #46

Closed
wants to merge 3 commits into from

Conversation

oliverbaehler
Copy link

This feature allows us to redirect traffic to external resources or additional ingress controllers :)

@STRRL
Copy link
Owner

STRRL commented Nov 25, 2023

Hi @oliverbaehler, sorry for the late response.

You work is awsome, but it changes the go package name so I am afraid that I could not merge it.

Would you like change "github.com/oliverbaehler/cloudflare-tunnel-ingress-controller/pkg/exposure" back to "github.com/STRRL/cloudflare-tunnel-ingress-controller/pkg/exposure"?

@codecov-commenter
Copy link

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (95c265e) 26.20% compared to head (e8c06de) 21.38%.
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/controller/controlled-cloudflared-connector.go 0.00% 35 Missing ⚠️
pkg/controller/ingress-controller.go 0.00% 27 Missing ⚠️
pkg/controller/transform.go 0.00% 27 Missing ⚠️
pkg/controller/finalizer.go 0.00% 22 Missing ⚠️
pkg/controller/utils.go 74.28% 9 Missing ⚠️
pkg/controller/annotations.go 95.00% 2 Missing and 1 partial ⚠️
pkg/cloudflare-controller/tunnel-client.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   26.20%   21.38%   -4.82%     
==========================================
  Files           9       11       +2     
  Lines         622      706      +84     
==========================================
- Hits          163      151      -12     
- Misses        449      554     +105     
+ Partials       10        1       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverbaehler
Copy link
Author

Oh hi @STRRL, yeah it's currently a fork of your project. Would you consider merging all the changes? Its quiet a lot .. :D. Then i will change the package path

@oliverbaehler
Copy link
Author

Sorry it seemed you have abandoned this project 3:

@STRRL
Copy link
Owner

STRRL commented Nov 27, 2023

Oh hi @STRRL, yeah it's currently a fork of your project. Would you consider merging all the changes? Its quiet a lot .. :D. Then i will change the package path

I am not sure. I just found your awesome work and I am trying to merge it.

Sorry it seemed you have abandoned this project 3:

yeah you're right, I really don't have much time for this project.

The fork is great!

I think I would better not try to merge your code directly. Maybe I would use your code as references and also implement some awesome features.

Thanks!

@STRRL
Copy link
Owner

STRRL commented Nov 27, 2023

I am going to close this PR.

If you want me to reference your awesome fork on this repos README.md, feel free to open another PR!

@STRRL STRRL closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants