Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable caching allocator #6393

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Optionally disable caching allocator #6393

merged 1 commit into from
Dec 6, 2023

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Dec 2, 2023

No description provided.

Copy link

codacy-production bot commented Dec 2, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3253ee11 94.87%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3253ee1) Report Missing Report Missing Report Missing
Head commit (8530848) 189610 161581 85.22%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6393) 39 37 94.87%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@hkaiser hkaiser merged commit 1cf717d into master Dec 6, 2023
63 of 71 checks passed
@hkaiser hkaiser deleted the caching_allocator branch December 6, 2023 16:54
@NK-Nikunj
Copy link
Member

https://github.com/STEllAR-GROUP/hpx/pull/6393/files#diff-bd1f43d73c88a8bdda46746af0e6bcdb9612ac716943cdc86a272028e326fc5dR116

Why use std::stack here when the operators involved in thread cache is the equivalent of a push_back and a pop_back? A std::vector should be better pick, no?

@hkaiser
Copy link
Member Author

hkaiser commented Dec 13, 2023

https://github.com/STEllAR-GROUP/hpx/pull/6393/files#diff-bd1f43d73c88a8bdda46746af0e6bcdb9612ac716943cdc86a272028e326fc5dR116

Why use std::stack here when the operators involved in thread cache is the equivalent of a push_back and a pop_back? A std::vector should be better pick, no?

Does it make a difference? But sure, please feel free to create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants