-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: removing intg tests, test_resolver.py #7588
base: master
Are you sure you want to change the base?
Conversation
dropping these dns resolution sanity tests. these tests do not test sssd at all but the test environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these tests covering the SSSD gethostbyname and getnetbyname interfaces? Do we have enough coverage with existing system tests for this?
These are SSSD NSS interfaces for hosts and network nsswitch lookups, it seems these interfaces and tests were added by Suse in 2019. I removed my ack based on this, to ensure we have test coverage for these interfaces even though we are not using them in typical sssd use cases. System tests with 'sss' added to |
A little more digging and after talking to @danlavu , we may have coverage here: |
For some context, we're doing some housekeeping with our tests and moving them to our new framework. We're happy to move them, but we may drop them if they're not used. |
Hi @danlavu, yes, it is used because after dropping nss_ldap it is the way to lookup hosts and networks stored in LDAP. I am happy to help if there is any problem migrating the tests. |
Multihost tests aren't run in upstream PR CI |
@alexey-tikhonov That's right; we recently removed the basic tests. Alright, I'm going to defer this PR until we move the tests to system tests. @scabrero Thank you, I don't forsee any problems moving the tests but will reach out if we do have any problems. |
dropping these dns resolution sanity tests. these tests do not test sssd at all but the test environment.