cert util: replace deprecated OpenSSL calls #7576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit-bose
force-pushed
the
openssl3_deprecated
branch
from
5669c85
to
4ec190c
Compare
sumit-bose
force-pushed
the
openssl3_deprecated
branch
2 times, most recently
from
8a9f06a
to
6dc8c6a
Compare
ikerexxe
reviewed
Sep 11, 2024
sumit-bose
force-pushed
the
openssl3_deprecated
branch
from
6dc8c6a
to
56e08e4
Compare
ikerexxe
approved these changes
Sep 11, 2024
sumit-bose
force-pushed
the
openssl3_deprecated
branch
from
56e08e4
to
602d66d
Compare
In OpenSSL 3.0 some of the calls we currently use in the utility functions to covert the public key from a X.509 certificate into an ssh public key got deprecated. This patch replaces them if OpenSSL 3.0 or newer is used. In contrast to the older calls which just returned references the new calls return the requested data in freshly allocated memory. To keep it consistent the data referenced by the old calls are copied into allocated memory as well. Resolves: SSSD#5861
sumit-bose
force-pushed
the
openssl3_deprecated
branch
from
602d66d
to
527cd18
Compare
alexey-tikhonov
approved these changes
Sep 17, 2024
|
Thank you, ACK. @ikerexxe, please take a look at the latest version. |
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenSSL 3.0 some of the calls we currently use in the utility
functions to covert the public key from a X.509 certificate into an ssh
public key got deprecated. This patch replaces them if OpenSSL 3.0 or
newer is used.
Resolves: #5861