Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create sysdb cache files from 'monitor' (and tests) #7558

Closed

Conversation

alexey-tikhonov
Copy link
Member

to avoid wrong files ownership if user used to run tools and SSSD differs.

@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. non-privileged labels Sep 3, 2024
@alexey-tikhonov alexey-tikhonov changed the title Don't create sysdb cache from tools Only create sysdb cache files from 'monitor' Sep 4, 2024
@alexey-tikhonov alexey-tikhonov changed the title Only create sysdb cache files from 'monitor' Only create sysdb cache files from 'monitor' (and tests) Sep 4, 2024
@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review September 5, 2024 11:06
@andreboscatto andreboscatto requested review from thalman and pbrezina and removed request for sumit-bose September 5, 2024 12:45
@alexey-tikhonov
Copy link
Member Author

(rebased)

src/db/sysdb.h Outdated Show resolved Hide resolved
It's reasonable to expect that nobody will attempt an upgrade
from DB version older than "0.16" (sssd-1.12) to "0.25"+
Everything else (providers, responders, tools) should only connect to.
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7558

  • master
    • 0aab0b1 - SYSDB: removed unused define
    • 842dbbb - SYSDB: only monitor (and tests) should create cache files
    • fb8aa35 - SYSDB: drop the code that upgrades from v < 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. non-privileged Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants